Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2150313002: NTP: Fix metrics recording crash by plumbing the necessary data to Java. (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

NTP: Fix metrics recording crash by plumbing the necessary data to Java. This has been broken since offline pages caused the refresh of the NTP MostVisitedSites to be asynchronous. BUG=612160 Review-Url: https://codereview.chromium.org/2105933002 Cr-Commit-Position: refs/heads/master@{#405079} (cherry picked from commit e14e21a2eb9ef970a6fc34f41290afe5e1015fc2) Committed: https://chromium.googlesource.com/chromium/src/+/5da565407f9804fca8b16a29de7bf8eabba79925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -60 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java View 4 chunks +24 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 4 chunks +11 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java View 4 chunks +11 lines, -9 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java View 4 chunks +9 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/android/ntp/most_visited_sites_bridge.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/android/ntp/most_visited_sites_bridge.cc View 3 chunks +22 lines, -3 lines 0 comments Download
M components/ntp_tiles.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_tiles/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_tiles/most_visited_sites.h View 2 chunks +34 lines, -2 lines 0 comments Download
M components/ntp_tiles/most_visited_sites.cc View 6 chunks +21 lines, -31 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Marc Treib
4 years, 5 months ago (2016-07-15 12:01:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5da565407f9804fca8b16a29de7bf8eabba79925.

Powered by Google App Engine
This is Rietveld 408576698