third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp - Issue 2150303002: Remove the prototype from all V8 functions that aren't constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp

Issue 2150303002: Remove the prototype from all V8 functions that aren't constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/DocumentWriteEvaluator.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp

index 1f50f696ddc93fb454c485b4f85f814f9190c52f..07e19fdd5c7b9350b14339c0ac6136a13bb6e011 100644

--- a/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp

@@ -60,6 +60,7 @@ static v8::Local<v8::Value> compileAndRunPrivateScript(ScriptState* scriptState,

v8::Local<v8::Value> importFunctionValue = privateScriptControllerObject->Get(context, v8String(isolate, "import")).ToLocalChecked();

if (importFunctionValue->IsUndefined()) {

v8::Local<v8::Function> function;

+ // This is a memory leak, FunctionTemplates are eternal.

if (!v8::FunctionTemplate::New(isolate, importFunction)->GetFunction(context).ToLocal(&function)

|| !v8CallBoolean(privateScriptControllerObject->Set(context, v8String(isolate, "import"), function))) {

fprintf(stderr, "Private script error: Setting import function failed. (Class name = %s)\n", scriptClassName.utf8().data());