Revert of Simplify RenderFrameImpl::decidePolicyForNavigation and avoid DCHECK

Revert of Simplify RenderFrameImpl::decidePolicyForNavigation and avoid DCHECK (patchset #2 id:20001 of https://codereview.chromium.org/2153573002/ )

Reason for revert:
Broke a layout test fast/events/popup-allowed-from-gesture-initiated-form-submit.html .

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&tests=popup-allowed-from-gesture-initiated-form-submit.html

Original issue's description:
> Simplify RenderFrameImpl::decidePolicyForNavigation and avoid DCHECK.
>
> DCHECK can be tripped when there is a chain of openers or when the
> opener has been cleared. The subsequent comparison against file:
> fails, and we may make a browser navigation where one could have
> been avoided, but it is still correct.
>
> Since it is still correct, we can simplify the check, perhaps
> forking in more cases that we used to, but that doesn't matter.
>
> BUG=622509
> R=creis@chromium.org
>
> Committed: https://crrev.com/6573f1eaf729320beeaf776674b124bfe5c330bb
> Cr-Commit-Position: refs/heads/master@{#405609}

TBR=creis@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622509, 628478
Committed: https://crrev.com/11f3ed430923329885682d50057217041ce661e1
Cr-Commit-Position: refs/heads/master@{#405694}

[tkent, 2016-07-15 04:15:17]

Created Revert of Simplify RenderFrameImpl::decidePolicyForNavigation and avoid
DCHECK

[tkent, 2016-07-15 04:16:03]

Description was changed from

==========
Revert of Simplify RenderFrameImpl::decidePolicyForNavigation and avoid DCHECK
(patchset #2 id:20001 of https://codereview.chromium.org/2153573002/ )

Reason for revert:
Broke a layout test
fast/events/popup-allowed-from-gesture-initiated-form-submit.html .

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec...


Original issue's description:
> Simplify RenderFrameImpl::decidePolicyForNavigation and avoid DCHECK.
> 
> DCHECK can be tripped when there is a chain of openers or when the
> opener has been cleared. The subsequent comparison against file:
> fails, and we may make a browser navigation where one could have
> been avoided, but it is still correct.
> 
> Since it is still correct, we can simplify the check, perhaps
> forking in more cases that we used to, but that doesn't matter.
> 
> BUG=622509
> R=creis@chromium.org
> 
> Committed: https://crrev.com/6573f1eaf729320beeaf776674b124bfe5c330bb
> Cr-Commit-Position: refs/heads/master@{#405609}

TBR=creis@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622509
==========

to

==========
Revert of Simplify RenderFrameImpl::decidePolicyForNavigation and avoid DCHECK
(patchset #2 id:20001 of https://codereview.chromium.org/2153573002/ )

Reason for revert:
Broke a layout test
fast/events/popup-allowed-from-gesture-initiated-form-submit.html .

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec...


Original issue's description:
> Simplify RenderFrameImpl::decidePolicyForNavigation and avoid DCHECK.
> 
> DCHECK can be tripped when there is a chain of openers or when the
> opener has been cleared. The subsequent comparison against file:
> fails, and we may make a browser navigation where one could have
> been avoided, but it is still correct.
> 
> Since it is still correct, we can simplify the check, perhaps
> forking in more cases that we used to, but that doesn't matter.
> 
> BUG=622509
> R=creis@chromium.org
> 
> Committed: https://crrev.com/6573f1eaf729320beeaf776674b124bfe5c330bb
> Cr-Commit-Position: refs/heads/master@{#405609}

TBR=creis@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622509, 628478
==========

[tkent, 2016-07-15 04:16:07]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-07-15 04:16:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 04:16:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-15 04:18:13]

Description was changed from

==========
Revert of Simplify RenderFrameImpl::decidePolicyForNavigation and avoid DCHECK
(patchset #2 id:20001 of https://codereview.chromium.org/2153573002/ )

Reason for revert:
Broke a layout test
fast/events/popup-allowed-from-gesture-initiated-form-submit.html .

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec...


Original issue's description:
> Simplify RenderFrameImpl::decidePolicyForNavigation and avoid DCHECK.
> 
> DCHECK can be tripped when there is a chain of openers or when the
> opener has been cleared. The subsequent comparison against file:
> fails, and we may make a browser navigation where one could have
> been avoided, but it is still correct.
> 
> Since it is still correct, we can simplify the check, perhaps
> forking in more cases that we used to, but that doesn't matter.
> 
> BUG=622509
> R=creis@chromium.org
> 
> Committed: https://crrev.com/6573f1eaf729320beeaf776674b124bfe5c330bb
> Cr-Commit-Position: refs/heads/master@{#405609}

TBR=creis@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622509, 628478
==========

to

==========
Revert of Simplify RenderFrameImpl::decidePolicyForNavigation and avoid DCHECK
(patchset #2 id:20001 of https://codereview.chromium.org/2153573002/ )

Reason for revert:
Broke a layout test
fast/events/popup-allowed-from-gesture-initiated-form-submit.html .

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec...

Original issue's description:
> Simplify RenderFrameImpl::decidePolicyForNavigation and avoid DCHECK.
>
> DCHECK can be tripped when there is a chain of openers or when the
> opener has been cleared. The subsequent comparison against file:
> fails, and we may make a browser navigation where one could have
> been avoided, but it is still correct.
>
> Since it is still correct, we can simplify the check, perhaps
> forking in more cases that we used to, but that doesn't matter.
>
> BUG=622509
> R=creis@chromium.org
>
> Committed: https://crrev.com/6573f1eaf729320beeaf776674b124bfe5c330bb
> Cr-Commit-Position: refs/heads/master@{#405609}

TBR=creis@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622509, 628478

Committed: https://crrev.com/11f3ed430923329885682d50057217041ce661e1
Cr-Commit-Position: refs/heads/master@{#405694}
==========

[commit-bot: I haz the power, 2016-07-15 04:18:14]

Patchset 1 (id:??) landed as
https://crrev.com/11f3ed430923329885682d50057217041ce661e1
Cr-Commit-Position: refs/heads/master@{#405694}