Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 215023002: Rename PrivateMode enum values: (Closed)

Created:
6 years, 9 months ago by Ryan Hamilton
Modified:
6 years, 8 months ago
Reviewers:
mef, Nicolas Zea
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Rename PrivateMode enum values: kPrivacyModeDisabled => PRIVACY_MODE_DISABLED kPrivacyModeEnabled => PRIVACY_MODE_ENABLED To match the chromium style guide: Though the Google C++ Style Guide now says to use kConstantNaming for enums, Chromium was written using MACRO_STYLE naming. Continue to use this style for consistency. R=mef@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260281 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260729

Patch Set 1 #

Patch Set 2 : Fix more uses #

Patch Set 3 : Rebase and Fix #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -96 lines) Patch
M chrome/browser/net/preconnect.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/connection_factory_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/proxy_resolving_client_socket.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/base/privacy_mode.h View 1 chunk +2 lines, -3 lines 0 comments Download
M net/http/disk_cache_based_quic_server_info_unittest.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_request_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config_test.cc View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session_key.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session_key_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_pool_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket_stream/socket_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_key.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_pool_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_websocket_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_bin.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_http_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/websockets/websocket_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_job_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 40 (0 generated)
Ryan Hamilton
6 years, 9 months ago (2014-03-27 17:16:35 UTC) #1
mef
lgtm
6 years, 9 months ago (2014-03-27 18:31:10 UTC) #2
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 9 months ago (2014-03-27 19:03:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/215023002/1
6 years, 9 months ago (2014-03-27 19:06:48 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 19:51:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 9 months ago (2014-03-27 19:51:34 UTC) #6
Ryan Hamilton
zea: jingle/ and google_apis/gcm/ approval, please.
6 years, 9 months ago (2014-03-27 22:42:36 UTC) #7
Nicolas Zea
LGTM. In the future feel free to TBR me for rename changes like this.
6 years, 9 months ago (2014-03-28 18:21:15 UTC) #8
Ryan Hamilton
On 2014/03/28 18:21:15, Nicolas Zea wrote: > LGTM. In the future feel free to TBR ...
6 years, 9 months ago (2014-03-28 19:00:44 UTC) #9
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 9 months ago (2014-03-28 19:00:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/215023002/20001
6 years, 9 months ago (2014-03-28 19:04:09 UTC) #11
commit-bot: I haz the power
Change committed as 260281
6 years, 9 months ago (2014-03-28 21:18:00 UTC) #12
Ryan Hamilton
A revert of this CL has been created in https://codereview.chromium.org/217053010/ by rch@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-28 22:08:26 UTC) #13
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 9 months ago (2014-03-28 22:31:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/215023002/40001
6 years, 9 months ago (2014-03-28 22:47:58 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 00:24:50 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-29 00:24:51 UTC) #17
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 9 months ago (2014-03-29 00:48:57 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/215023002/40001
6 years, 9 months ago (2014-03-29 00:49:54 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 02:25:48 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-29 02:25:49 UTC) #21
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 9 months ago (2014-03-29 02:37:07 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/215023002/40001
6 years, 9 months ago (2014-03-29 02:38:11 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 04:08:49 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-29 04:08:49 UTC) #25
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 8 months ago (2014-03-29 14:07:17 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/215023002/40001
6 years, 8 months ago (2014-03-29 14:07:27 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 15:36:18 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 15:36:18 UTC) #29
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 8 months ago (2014-03-30 17:52:38 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/215023002/40001
6 years, 8 months ago (2014-03-30 17:52:49 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-30 18:42:51 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-30 18:42:52 UTC) #33
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 8 months ago (2014-03-31 19:49:56 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/215023002/40001
6 years, 8 months ago (2014-03-31 19:50:50 UTC) #35
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 21:22:04 UTC) #36
commit-bot: I haz the power
Failed to apply patch for net/tools/quic/quic_client_bin.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-03-31 21:22:05 UTC) #37
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 8 months ago (2014-03-31 22:18:54 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/215023002/60001
6 years, 8 months ago (2014-03-31 22:20:12 UTC) #39
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 01:28:55 UTC) #40
Message was sent while issue was closed. 
Change committed as 260729

Powered by Google App Engine
This is Rietveld 408576698