Issue 21502002: Revert "Speed-up 'new TypedArray(arrayLike)'."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21502002: Revert "Speed-up 'new TypedArray(arrayLike)'." (Closed)

Created:
7 years, 4 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 4 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Speed-up 'new TypedArray(arrayLike)'." This reverts commit r15998 for breaking NaCl build. TBR=bmeurer@chromium.org

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+50 lines, -165 lines)			Patch
include/v8.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download
src/d8.cc	View	1 chunk	+1 line, -8 lines	0 comments	Download
src/runtime.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
src/runtime.cc	View	4 chunks	+43 lines, -138 lines	0 comments	Download
src/typedarray.js	View	1 chunk	+5 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

Hm, why revert? Why not simply fix the GCC warnings?

7 years, 4 months ago (2013-08-01 08:53:39 UTC) #1

Dmitry Lomov (no reviews)

7 years, 4 months ago (2013-08-02 12:00:09 UTC) #3

Message was sent while issue was closed.

This was committed in https://code.google.com/p/v8/source/detail?r=16003, I
dunno why the git cl dcommit failed to update this.