extensions/common/features/manifest_feature.h - Issue 2150193002: [Extensions] Add a SimpleFeature::Validate function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/manifest_feature.h

Issue 2150193002: [Extensions] Add a SimpleFeature::Validate function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Istiaque's Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/features/manifest_feature.h

diff --git a/extensions/common/features/manifest_feature.h b/extensions/common/features/manifest_feature.h

index ab77d028df8f56dc24da3925b2434fd073c0a1ab..59b9bfa6aaa316730803754b057658ea81660e37 100644

--- a/extensions/common/features/manifest_feature.h

+++ b/extensions/common/features/manifest_feature.h

@@ -22,7 +22,7 @@ class ManifestFeature : public SimpleFeature {

const GURL& url,

Feature::Platform platform) const override;

- std::string Parse(const base::DictionaryValue* value) override;

+ bool Validate(std::string* error) override;

};

} // namespace extensions

« no previous file with comments | « extensions/common/features/json_feature_provider.cc ('k') | extensions/common/features/manifest_feature.cc » ('j') | no next file with comments »