Issue 215017: Fix extension toolstrip background update code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 215017: Fix extension toolstrip background update code (Closed)

Created:
11 years, 3 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, pam+watch_chromium.org, Ben Goodger (Google), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

While fixing bug 22070 (Toolstrip theme background not updated when resizing Chrome window) I added code to trigger repainting the background on resize. This flushed out a problem (Skia exceptions) that was causing the extension tests to become flaky on the bots (bug 22135). I've changed the code to do a deep copy on the subset bitmap we get before passing it down to the renderer, which causes Skia to not go haywire when drawing the background. That makes it possible to fix bug 22070, which now causes the background to be updated on resize. There is also now no need to set the background_needs_repaint_ flag to true before calling Layout. We also don't need to keep track of whether we are detached or not, we just need to monitor the background_needs_repaint_ flag. BUG=22070, 22135 TEST=Monitor the bots and see if the tests become flaky again. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26526

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -47 lines)			Patch
M	chrome/browser/extensions/extension_browsertests_misc.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/views/extensions/extension_shelf.h	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/browser/views/extensions/extension_shelf.cc	View	9 chunks	+28 lines, -36 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

hooray to lots of deleted code.

lgtm

Expand Messages | Collapse Messages