third_party/WebKit/LayoutTests/paint/invalidation/ruby-text.html - Issue 2150143002: Don't over-flip when mapping visual rects for Ruby text.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/invalidation/ruby-text.html

Issue 2150143002: Don't over-flip when mapping visual rects for Ruby text. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tests. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/paint/invalidation/ruby-text-expected.txt » ('j') | third_party/WebKit/LayoutTests/paint/invalidation/ruby-text-flipped-blocks.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src="../../fast/repaint/resources/text-based-repaint.js"></script>

	3 <div>

	4 <ruby id="outside">b<rt id="inside">c</rt></ruby>

	5 </div>

	6 <script>

	7 // Tests that ruby text paint invalidation works correctly. The result should

	8 // be horizontal text as a pink "b" with a smaller blue "c" above it.

	9 onload = runRepaintTest;
	chrishtr 2016/07/15 01:24:29 runRepaintAndPixelTest is easy, and Xianzhu showed runRepaintAndPixelTest is easy, and Xianzhu showed a few weeks ago that it adds a trivial amount to cycle times. wkorman 2016/07/15 01:59:23 Done. I mostly felt uneasy about dumping binary im Show quoted text On 2016/07/15 at 01:24:29, chrishtr wrote: > runRepaintAndPixelTest is easy, and Xianzhu showed a few weeks ago that it adds a trivial amount to cycle times. Done. I mostly felt uneasy about dumping binary images into our source tree unnecessarily but I'm happy to change. Also reworked tests to use Ahem.
	10 function repaintTest() {

	11 outside.style.color = "pink";

	12 inside.style.color = "blue";

	13 }

	14 </script>

OLD	NEW