Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: src/hydrogen.cc

Issue 21501002: Pretenure heap number in high promotino mode if a store requires a mutable heap number to be alloca… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4513 matching lines...) Expand 10 before | Expand all | Expand 10 after
4524 4524
4525 HStoreNamedField *instr; 4525 HStoreNamedField *instr;
4526 if (FLAG_track_double_fields && field_access.representation().IsDouble()) { 4526 if (FLAG_track_double_fields && field_access.representation().IsDouble()) {
4527 HObjectAccess heap_number_access = 4527 HObjectAccess heap_number_access =
4528 field_access.WithRepresentation(Representation::Tagged()); 4528 field_access.WithRepresentation(Representation::Tagged());
4529 if (transition_to_field) { 4529 if (transition_to_field) {
4530 // The store requires a mutable HeapNumber to be allocated. 4530 // The store requires a mutable HeapNumber to be allocated.
4531 NoObservableSideEffectsScope no_side_effects(this); 4531 NoObservableSideEffectsScope no_side_effects(this);
4532 HInstruction* heap_number_size = Add<HConstant>(HeapNumber::kSize); 4532 HInstruction* heap_number_size = Add<HConstant>(HeapNumber::kSize);
4533 HInstruction* heap_number = Add<HAllocate>(heap_number_size, 4533 HInstruction* heap_number = Add<HAllocate>(heap_number_size,
4534 HType::HeapNumber(), NOT_TENURED, HEAP_NUMBER_TYPE); 4534 HType::HeapNumber(), isolate()->heap()->GetPretenureMode(),
4535 HEAP_NUMBER_TYPE);
4535 AddStoreMapConstant(heap_number, isolate()->factory()->heap_number_map()); 4536 AddStoreMapConstant(heap_number, isolate()->factory()->heap_number_map());
4536 Add<HStoreNamedField>(heap_number, HObjectAccess::ForHeapNumberValue(), 4537 Add<HStoreNamedField>(heap_number, HObjectAccess::ForHeapNumberValue(),
4537 value); 4538 value);
4538 instr = New<HStoreNamedField>(object, heap_number_access, 4539 instr = New<HStoreNamedField>(object, heap_number_access,
4539 heap_number); 4540 heap_number);
4540 } else { 4541 } else {
4541 // Already holds a HeapNumber; load the box and write its value field. 4542 // Already holds a HeapNumber; load the box and write its value field.
4542 HInstruction* heap_number = Add<HLoadNamedField>(object, 4543 HInstruction* heap_number = Add<HLoadNamedField>(object,
4543 heap_number_access); 4544 heap_number_access);
4544 heap_number->set_type(HType::HeapNumber()); 4545 heap_number->set_type(HType::HeapNumber());
(...skipping 5235 matching lines...) Expand 10 before | Expand all | Expand 10 after
9780 if (ShouldProduceTraceOutput()) { 9781 if (ShouldProduceTraceOutput()) {
9781 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 9782 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
9782 } 9783 }
9783 9784
9784 #ifdef DEBUG 9785 #ifdef DEBUG
9785 graph_->Verify(false); // No full verify. 9786 graph_->Verify(false); // No full verify.
9786 #endif 9787 #endif
9787 } 9788 }
9788 9789
9789 } } // namespace v8::internal 9790 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698