Add IPC support for gfx::ColorSpace

Add IPC support for gfx::ColorSpace

This structure, passed browser->renderer, is not necessarily an
ICC profile, so we shouldn't be passing it around as a raw ICC
profile.

This also adds the build targets that we'll be using for other color
related structures in the near future. In particular, we will be adding a
color space structure that cannot be a full ICC profile (because they
are heavy, and sending them renderer->browser would be unsafe).

BUG=622133
Committed: https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202
Cr-Commit-Position: refs/heads/master@{#406363}

[ccameron, 2016-07-14 21:59:01]

Description was changed from

==========
Add IPC support for gfx::ColorSpace

This structure is not necessarily an ICC profile, so we shouldn't be
passing it around as a raw ICC profile.

This also adds the build targets that we'll be using for other color
related structures in the near future.

BUG=622133
==========

to

==========
Add IPC support for gfx::ColorSpace

This structure is not necessarily an ICC profile, so we shouldn't be
passing it around as a raw ICC profile.

This also adds the build targets that we'll be using for other color
related structures in the near future. In particular, we will be adding a
color space structure that cannot be a full ICC profile (because they
are heavy, and sending them renderer->browser would be unsafe).

BUG=622133
==========

[ccameron, 2016-07-14 21:59:01]

ccameron@chromium.org changed reviewers:
+ dcheng@chromium.org

[ccameron, 2016-07-14 21:59:44]

Description was changed from

==========
Add IPC support for gfx::ColorSpace

This structure is not necessarily an ICC profile, so we shouldn't be
passing it around as a raw ICC profile.

This also adds the build targets that we'll be using for other color
related structures in the near future. In particular, we will be adding a
color space structure that cannot be a full ICC profile (because they
are heavy, and sending them renderer->browser would be unsafe).

BUG=622133
==========

to

==========
Add IPC support for gfx::ColorSpace

This structure, passed browser->renderer, is not necessarily an
ICC profile, so we shouldn't be passing it around as a raw ICC
profile.

This also adds the build targets that we'll be using for other color
related structures in the near future. In particular, we will be adding a
color space structure that cannot be a full ICC profile (because they
are heavy, and sending them renderer->browser would be unsafe).

BUG=622133
==========

[ccameron, 2016-07-14 21:59:48]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 22:00:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 22:07:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 22:07:12]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ccameron, 2016-07-14 22:32:16]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 22:33:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 00:06:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 00:06:36]

Dry run: This issue passed the CQ dry run.

[ccameron, 2016-07-18 17:23:56]

post-weekend ping

[dcheng, 2016-07-19 05:17:41]

https://codereview.chromium.org/2150013003/diff/40001/ui/gfx/ipc/color/gfx_pa...
File ui/gfx/ipc/color/gfx_param_traits.cc (right):

https://codereview.chromium.org/2150013003/diff/40001/ui/gfx/ipc/color/gfx_pa...
ui/gfx/ipc/color/gfx_param_traits.cc:27: uint32_t type =
static_cast<uint32_t>(p.type_);
Can we define a paramtraits for the enum instead of casting like htis?

[ccameron, 2016-07-19 05:56:50]

Good point -- done.

https://codereview.chromium.org/2150013003/diff/40001/ui/gfx/ipc/color/gfx_pa...
File ui/gfx/ipc/color/gfx_param_traits.cc (right):

https://codereview.chromium.org/2150013003/diff/40001/ui/gfx/ipc/color/gfx_pa...
ui/gfx/ipc/color/gfx_param_traits.cc:27: uint32_t type =
static_cast<uint32_t>(p.type_);
On 2016/07/19 05:17:41, dcheng wrote:
> Can we define a paramtraits for the enum instead of casting like htis?

Good point -- done.

[dcheng, 2016-07-19 06:13:18]

lgtm

[ccameron, 2016-07-19 16:39:03]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-07-19 16:39:14]

The CQ bit was unchecked by ccameron@chromium.org

[ccameron, 2016-07-19 16:39:30]

ccameron@chromium.org changed reviewers:
+ avi@chromium.org

[ccameron, 2016-07-19 16:39:31]

Adding avi@ for content/ stamp

[Avi (use Gerrit), 2016-07-19 17:12:59]

LGTM

You need an IPC review.

[ccameron, 2016-07-19 17:37:30]

Thanks! (yup, dcheng was ipc)

[ccameron, 2016-07-19 17:37:35]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-07-19 17:37:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 17:43:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 17:43:26]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ccameron, 2016-07-19 18:29:17]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 18:29:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 19:43:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 19:43:52]

Dry run: This issue passed the CQ dry run.

[ccameron, 2016-07-19 20:04:32]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-07-19 20:04:33]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2150013003/#ps100001
(title: "git cl try")

[commit-bot: I haz the power, 2016-07-19 20:05:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 20:12:38]

Description was changed from

==========
Add IPC support for gfx::ColorSpace

This structure, passed browser->renderer, is not necessarily an
ICC profile, so we shouldn't be passing it around as a raw ICC
profile.

This also adds the build targets that we'll be using for other color
related structures in the near future. In particular, we will be adding a
color space structure that cannot be a full ICC profile (because they
are heavy, and sending them renderer->browser would be unsafe).

BUG=622133
==========

to

==========
Add IPC support for gfx::ColorSpace

This structure, passed browser->renderer, is not necessarily an
ICC profile, so we shouldn't be passing it around as a raw ICC
profile.

This also adds the build targets that we'll be using for other color
related structures in the near future. In particular, we will be adding a
color space structure that cannot be a full ICC profile (because they
are heavy, and sending them renderer->browser would be unsafe).

BUG=622133
==========

[commit-bot: I haz the power, 2016-07-19 20:12:39]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-19 20:13:00]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 20:14:49]

Description was changed from

==========
Add IPC support for gfx::ColorSpace

This structure, passed browser->renderer, is not necessarily an
ICC profile, so we shouldn't be passing it around as a raw ICC
profile.

This also adds the build targets that we'll be using for other color
related structures in the near future. In particular, we will be adding a
color space structure that cannot be a full ICC profile (because they
are heavy, and sending them renderer->browser would be unsafe).

BUG=622133
==========

to

==========
Add IPC support for gfx::ColorSpace

This structure, passed browser->renderer, is not necessarily an
ICC profile, so we shouldn't be passing it around as a raw ICC
profile.

This also adds the build targets that we'll be using for other color
related structures in the near future. In particular, we will be adding a
color space structure that cannot be a full ICC profile (because they
are heavy, and sending them renderer->browser would be unsafe).

BUG=622133

Committed: https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202
Cr-Commit-Position: refs/heads/master@{#406363}
==========

[commit-bot: I haz the power, 2016-07-19 20:14:51]

Patchset 6 (id:??) landed as
https://crrev.com/e0d9f3857bedccbd50584c260d071b4ad8ee2202
Cr-Commit-Position: refs/heads/master@{#406363}