Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: chrome/browser/ui/views/tabs/tab.h

Issue 2150013002: Move private static members and methods into namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/tabs/tab.cc » ('j') | chrome/browser/ui/views/tabs/tab.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tabs/tab.h
diff --git a/chrome/browser/ui/views/tabs/tab.h b/chrome/browser/ui/views/tabs/tab.h
index bc31de495892b14f6dedddf680657c117b615367..c00e9737626861fe2a4fcc500ce0abdd94f6b61f 100644
--- a/chrome/browser/ui/views/tabs/tab.h
+++ b/chrome/browser/ui/views/tabs/tab.h
@@ -185,13 +185,6 @@ class Tab : public gfx::AnimationDelegate,
class TabCloseButton;
class ThrobberView;
- // All metadata necessary to uniquely identify a cached image.
- struct ImageCacheEntryMetadata;
-
- // A cached image and the metadata used to generate it.
- struct ImageCacheEntry;
- typedef std::list<ImageCacheEntry> ImageCache;
-
// gfx::AnimationDelegate:
void AnimationProgressed(const gfx::Animation* animation) override;
void AnimationCanceled(const gfx::Animation* animation) override;
@@ -252,11 +245,6 @@ class Tab : public gfx::AnimationDelegate,
int fill_id,
bool has_custom_image,
int y_offset);
- void PaintTabFill(gfx::Canvas* canvas,
- gfx::ImageSkia* fill_image,
- int x_offset,
- int y_offset,
- bool is_active);
// Paints the pinned tab title changed indicator and |favicon_|. |favicon_|
// may be null. |favicon_draw_bounds| is |favicon_bounds_| adjusted for rtl
@@ -307,25 +295,9 @@ class Tab : public gfx::AnimationDelegate,
// Schedules repaint task for icon.
void ScheduleIconPaint();
- // Computes a path corresponding to the tab's content region inside the outer
- // stroke.
- void GetFillPath(float scale, SkPath* path) const;
-
- // Computes a path corresponding to the tab's outer border for a given |scale|
- // and stores it in |path|. If |extend_to_top| is true, the path is extended
- // vertically to the top of the tab bounds. The caller uses this for Fitts'
- // Law purposes in maximized/fullscreen mode.
- void GetBorderPath(float scale, bool extend_to_top, SkPath* path) const;
-
// Returns the rectangle for the light bar in immersive mode.
gfx::Rect GetImmersiveBarRect() const;
- // Performs a one-time initialization of static resources such as tab images.
- static void InitTabResources();
-
- // Loads the images to be used for the tab background.
- static void LoadTabImages();
-
// The controller, never NULL.
TabController* const controller_;
@@ -374,17 +346,6 @@ class Tab : public gfx::AnimationDelegate,
// The offset used to paint the inactive background image.
gfx::Point background_offset_;
- struct TabImages {
- gfx::ImageSkia* image_l;
- gfx::ImageSkia* image_c;
- gfx::ImageSkia* image_r;
- int l_width;
- int r_width;
- };
- static TabImages active_images_;
- static TabImages inactive_images_;
- static TabImages mask_images_;
-
// Whether we're showing the icon. It is cached so that we can detect when it
// changes and layout appropriately.
bool showing_icon_;
@@ -405,10 +366,6 @@ class Tab : public gfx::AnimationDelegate,
// and thus may be null.
gfx::ImageSkia favicon_;
- // As the majority of the tabs are inactive, and painting tabs is slowish,
- // we cache a handful of the inactive tab backgrounds here.
- static ImageCache* image_cache_;
-
DISALLOW_COPY_AND_ASSIGN(Tab);
};
« no previous file with comments | « no previous file | chrome/browser/ui/views/tabs/tab.cc » ('j') | chrome/browser/ui/views/tabs/tab.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698