Move private static members and methods into namespace

Move private static members and methods into namespace

BUG=621139
This is in preparation for https://codereview.chromium.org/2118853002/,
which will also move PaintTabBackgroundUsingFillId() into namespace.
This CL is moving everything it depends on out of Tab.

Committed: https://crrev.com/875add8fab36691c4bb5a32fbc503e986e07b743
Cr-Commit-Position: refs/heads/master@{#405620}

[Greg Levin, 2016-07-14 18:26:45]

https://codereview.chromium.org/2150013002/diff/1/chrome/browser/ui/views/tab...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/2150013002/diff/1/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab.cc:194: static ImageCache* image_cache = NULL;
Is there a preferred naming convention for static file-scoped variables? 
s_image_cache?  image_cache_?

https://codereview.chromium.org/2150013002/diff/1/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab.cc:280: // stroke.
These three functions were *almost* static (just needed height() & width(), now
passed as |size| arg).  They are called by PaintTabBackgroundUsingFillId(),
which will be moved to namespace by https://codereview.chromium.org/2118853002/.

[Greg Levin, 2016-07-14 19:51:39]

glevin@chromium.org changed reviewers:
+ msw@chromium.org

[Greg Levin, 2016-07-14 19:51:39]

msw@- pkasting@ and sky@ are out of town this week.  Could you have a look at
this refactoring CL?  Thanks!

[msw, 2016-07-14 20:14:49]

lgtm

https://codereview.chromium.org/2150013002/diff/1/chrome/browser/ui/views/tab...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/2150013002/diff/1/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab.cc:194: static ImageCache* image_cache = NULL;
On 2016/07/14 18:26:45, Greg Levin wrote:
> Is there a preferred naming convention for static file-scoped variables? 
> s_image_cache?  image_cache_?

I think 'g' is commonly used as a prefix for file-local 'global' static
variables, ie. |g_image_cache|. That said, it seems like a fair number of places
don't adorn the identifier; whatever you decide here, do the same for the static
TabImages instances below. nit: nullptr

https://codereview.chromium.org/2150013002/diff/1/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab.cc:280: // stroke.
On 2016/07/14 18:26:45, Greg Levin wrote:
> These three functions were *almost* static (just needed height() & width(),
now
> passed as |size| arg).  They are called by PaintTabBackgroundUsingFillId(),
> which will be moved to namespace by
https://codereview.chromium.org/2118853002/.

Acknowledged.

[msw, 2016-07-14 20:14:49]

lgtm

https://codereview.chromium.org/2150013002/diff/1/chrome/browser/ui/views/tab...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/2150013002/diff/1/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab.cc:194: static ImageCache* image_cache = NULL;
On 2016/07/14 18:26:45, Greg Levin wrote:
> Is there a preferred naming convention for static file-scoped variables? 
> s_image_cache?  image_cache_?

I think 'g' is commonly used as a prefix for file-local 'global' static
variables, ie. |g_image_cache|. That said, it seems like a fair number of places
don't adorn the identifier; whatever you decide here, do the same for the static
TabImages instances below. nit: nullptr

https://codereview.chromium.org/2150013002/diff/1/chrome/browser/ui/views/tab...
chrome/browser/ui/views/tabs/tab.cc:280: // stroke.
On 2016/07/14 18:26:45, Greg Levin wrote:
> These three functions were *almost* static (just needed height() & width(),
now
> passed as |size| arg).  They are called by PaintTabBackgroundUsingFillId(),
> which will be moved to namespace by
https://codereview.chromium.org/2118853002/.

Acknowledged.

[Greg Levin, 2016-07-14 22:36:48]

The CQ bit was checked by glevin@chromium.org

[Greg Levin, 2016-07-14 22:36:49]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2150013002/#ps20001
(title: "Small cleanup from review")

[commit-bot: I haz the power, 2016-07-14 22:37:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 23:16:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-14 23:16:16]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 23:17:48]

Description was changed from

==========
Move private static members and methods into namespace

BUG=621139

This is in preparation for https://codereview.chromium.org/2118853002/,
which will also move PaintTabBackgroundUsingFillId() into namespace.
This CL is moving everything it depends on out of Tab.
==========

to

==========
Move private static members and methods into namespace

BUG=621139

This is in preparation for https://codereview.chromium.org/2118853002/,
which will also move PaintTabBackgroundUsingFillId() into namespace.
This CL is moving everything it depends on out of Tab.

Committed: https://crrev.com/875add8fab36691c4bb5a32fbc503e986e07b743
Cr-Commit-Position: refs/heads/master@{#405620}
==========

[commit-bot: I haz the power, 2016-07-14 23:17:49]

Patchset 2 (id:??) landed as
https://crrev.com/875add8fab36691c4bb5a32fbc503e986e07b743
Cr-Commit-Position: refs/heads/master@{#405620}