Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: chrome/renderer/render_view.cc

Issue 215001: Fix mouse over status bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/render_view.h" 5 #include "chrome/renderer/render_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 1452 matching lines...) Expand 10 before | Expand all | Expand 10 after
1463 msg->set_pump_messages_event(modal_dialog_event_.get()); 1463 msg->set_pump_messages_event(modal_dialog_event_.get());
1464 Send(msg); 1464 Send(msg);
1465 1465
1466 return success; 1466 return success;
1467 } 1467 }
1468 1468
1469 void RenderView::setStatusText(const WebString& text) { 1469 void RenderView::setStatusText(const WebString& text) {
1470 } 1470 }
1471 1471
1472 void RenderView::setMouseOverURL(const WebURL& url) { 1472 void RenderView::setMouseOverURL(const WebURL& url) {
1473 GURL latest_url; 1473 GURL latest_url(url);
1474 if (latest_url == target_url_) 1474 if (latest_url == target_url_)
1475 return; 1475 return;
1476 // Tell the browser to display a destination link. 1476 // Tell the browser to display a destination link.
1477 if (target_url_status_ == TARGET_INFLIGHT || 1477 if (target_url_status_ == TARGET_INFLIGHT ||
1478 target_url_status_ == TARGET_PENDING) { 1478 target_url_status_ == TARGET_PENDING) {
1479 // If we have a request in-flight, save the URL to be sent when we 1479 // If we have a request in-flight, save the URL to be sent when we
1480 // receive an ACK to the in-flight request. We can happily overwrite 1480 // receive an ACK to the in-flight request. We can happily overwrite
1481 // any existing pending sends. 1481 // any existing pending sends.
1482 pending_target_url_ = latest_url; 1482 pending_target_url_ = latest_url;
1483 target_url_status_ = TARGET_PENDING; 1483 target_url_status_ = TARGET_PENDING;
(...skipping 2024 matching lines...) Expand 10 before | Expand all | Expand 10 after
3508 // TODO(darin): There's actually no reason for this to be here. We should 3508 // TODO(darin): There's actually no reason for this to be here. We should
3509 // have the browser side manage the document tag. 3509 // have the browser side manage the document tag.
3510 #if defined(OS_MACOSX) 3510 #if defined(OS_MACOSX)
3511 if (!has_document_tag_) { 3511 if (!has_document_tag_) {
3512 // Make the call to get the tag. 3512 // Make the call to get the tag.
3513 Send(new ViewHostMsg_GetDocumentTag(routing_id_, &document_tag_)); 3513 Send(new ViewHostMsg_GetDocumentTag(routing_id_, &document_tag_));
3514 has_document_tag_ = true; 3514 has_document_tag_ = true;
3515 } 3515 }
3516 #endif 3516 #endif
3517 } 3517 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698