third_party/WebKit/Source/core/layout/LayoutBlock.cpp - Issue 2150003005: Add grid/flex layout support for <fieldset>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2150003005: Add grid/flex layout support for <fieldset> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert a11y test expectations & explicitely set a11y fieldset role to GroupRole Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

index 88c0166f0b993a1083e9301a771162f982c0cb5a..0a387ddc25d4876e42721d0d67e1d5c873cfbf35 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

@@ -1736,6 +1736,9 @@ LayoutBlock* LayoutBlock::createAnonymousWithParentAndDisplay(const LayoutObject

if (display == FLEX || display == INLINE_FLEX) {

newBox = LayoutFlexibleBox::createAnonymous(&parent->document());

newDisplay = FLEX;

+ } else if (display == GRID || display == INLINE_GRID) {

+ newBox = LayoutGrid::createAnonymous(&parent->document());

+ newDisplay = GRID;

} else {

newBox = LayoutBlockFlow::createAnonymous(&parent->document());

newDisplay = BLOCK;