third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-flex.html - Issue 2150003005: Add grid/flex layout support for <fieldset>

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-flex.html

Issue 2150003005: Add grid/flex layout support for <fieldset> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated TestExpectations and fixed legend-after-margin-vertical-writing-mode.html Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid.html » ('j') | third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	cbiesinger 2016/07/21 19:54:16 You should keep this line; we don't usually want t You should keep this line; we don't usually want to test in quirks mode (for all your tests) Gleb Lanbin 2016/07/21 20:49:01 Done. Show quoted text On 2016/07/21 19:54:16, cbiesinger wrote: > You should keep this line; we don't usually want to test in quirks mode (for all > your tests) Done.
	2 <html>

	3 <head>
	Manuel Rego 2016/07/20 06:00:23 You don't need html, head and body tags on this te You don't need html, head and body tags on this test, you can simply get rid of them. Gleb Lanbin 2016/07/21 18:25:30 Done. Show quoted text On 2016/07/20 06:00:23, Manuel Rego wrote: > You don't need html, head and body tags on this test, > you can simply get rid of them. Done.
	4 <title>Test Case with FIELDSET as flex container</title>
	Manuel Rego 2016/07/20 06:00:23 We don't usually use the title to describe the tes We don't usually use the title to describe the test, for that we use the file name. Gleb Lanbin 2016/07/21 18:25:31 Done. Show quoted text On 2016/07/20 06:00:23, Manuel Rego wrote: > We don't usually use the title to describe the test, > for that we use the file name. Done.
	5 <style>

	6 * {

	7 padding: 1em;
	Manuel Rego 2016/07/20 06:00:23 This is not needed. This is not needed. Gleb Lanbin 2016/07/21 18:25:31 Done. Show quoted text On 2016/07/20 06:00:23, Manuel Rego wrote: > This is not needed. Done.
	8 }

	9 </style>

	10 </head>

	11
	Manuel Rego 2016/07/20 06:00:23 It's usually nice to add a paragraph explaining wh It's usually nice to add a paragraph explaining what the test is checking and the expected result. In this case the expected result is clear in the text below though. Gleb Lanbin 2016/07/21 18:25:31 Done. Show quoted text On 2016/07/20 06:00:23, Manuel Rego wrote: > It's usually nice to add a paragraph explaining what the test is checking > and the expected result. > > In this case the expected result is clear in the text below though. Done.
	12 <body>

	13 <fieldset style="display: flex;">

	14 <legend>Fieldset with display: flex</legend>

	15 <div>these fields</div>

	16 <div>shouldn't be</div>

	17 <div>stacked vertically</div>

	18 </fieldset>

	19 </body>

	20 </html>
	Manuel Rego 2016/07/20 06:00:23 And last thing about the test, I don't see any goo And last thing about the test, I don't see any good reason to not be a reference test. The -exptected file could have something like: <fieldset> <legend>Fieldset with display: flex</legend> <div>these fieldsshouldn't bestacked vertically</div> </fieldset> Reference tests are much better as we won't need all the rebaselines, and they're platform independent. Gleb Lanbin 2016/07/21 18:25:31 Done. Show quoted text On 2016/07/20 06:00:23, Manuel Rego wrote: > And last thing about the test, > I don't see any good reason to not be a reference test. > The -exptected file could have something like: > <fieldset> > <legend>Fieldset with display: flex</legend> > <div>these fieldsshouldn't bestacked vertically</div> > </fieldset> > > Reference tests are much better as we won't need all the rebaselines, > and they're platform independent. Done.
OLD	NEW