Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

Issue 2150003005: Add grid/flex layout support for <fieldset> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert a11y test expectations & explicitely set a11y fieldset role to GroupRole Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 503 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 514
515 if (getNode()->nodeName() == "TIME") 515 if (getNode()->nodeName() == "TIME")
516 return TimeRole; 516 return TimeRole;
517 517
518 if (isEmbeddedObject()) 518 if (isEmbeddedObject())
519 return EmbeddedObjectRole; 519 return EmbeddedObjectRole;
520 520
521 if (isHTMLHRElement(*getNode())) 521 if (isHTMLHRElement(*getNode()))
522 return SplitterRole; 522 return SplitterRole;
523 523
524 if (isFieldset()) {
525 return GroupRole;
526 }
527
524 return UnknownRole; 528 return UnknownRole;
525 } 529 }
526 530
527 AccessibilityRole AXNodeObject::determineAccessibilityRole() 531 AccessibilityRole AXNodeObject::determineAccessibilityRole()
528 { 532 {
529 if (!getNode()) 533 if (!getNode())
530 return UnknownRole; 534 return UnknownRole;
531 535
532 if ((m_ariaRole = determineAriaRoleAttribute()) != UnknownRole) 536 if ((m_ariaRole = determineAriaRoleAttribute()) != UnknownRole)
533 return m_ariaRole; 537 return m_ariaRole;
(...skipping 2306 matching lines...) Expand 10 before | Expand all | Expand 10 after
2840 return placeholder; 2844 return placeholder;
2841 } 2845 }
2842 2846
2843 DEFINE_TRACE(AXNodeObject) 2847 DEFINE_TRACE(AXNodeObject)
2844 { 2848 {
2845 visitor->trace(m_node); 2849 visitor->trace(m_node);
2846 AXObject::trace(visitor); 2850 AXObject::trace(visitor);
2847 } 2851 }
2848 2852
2849 } // namespace blink 2853 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698