Revert of Make webkit_modules a split static library in non-component builds.

Revert of Make webkit_modules a split static library in non-component builds. (patchset #2 id:20001 of https://codereview.chromium.org/2145253003/ )

Reason for revert:
I suspect that this change can cause failure in the generate_build_files step on Windows.

Making a speculative revert to see if the issue is resolved.

See also:

https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chrome%20Win/builds/8974/steps/generate_build_files/logs/stdio

Original issue's description:
> Make webkit_modules a split static library in non-component builds.
>
> Previously this was force to a source set because it was too large for official Windows builds to handle as a static library.
>
> This uses the split_static_library template for non-component official Windows builds so it can be a static library now.
>
> BUG=627637
>
> Committed: https://crrev.com/eb0a50c30fdf3d7ca8f978fb55f363cf1f702b73
> Cr-Commit-Position: refs/heads/master@{#405618}

TBR=brucedawson@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=627637
Committed: https://crrev.com/52116563313f1ebe1e2b966b429d217442e3362b
Cr-Commit-Position: refs/heads/master@{#405726}

[henrika (OOO until Aug 14), 2016-07-15 08:38:18]

The CQ bit was checked by henrika@chromium.org

[henrika (OOO until Aug 14), 2016-07-15 08:38:18]

Created Revert of Make webkit_modules a split static library in non-component
builds.

[commit-bot: I haz the power, 2016-07-15 08:38:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 08:39:11]

Description was changed from

==========
Revert of Make webkit_modules a split static library in non-component builds.
(patchset #2 id:20001 of https://codereview.chromium.org/2145253003/ )

Reason for revert:
I suspect that this change can cause failure in the generate_build_files step on
Windows.

Making a speculative revert to see if the issue is resolved.

See also:

https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chro...

Original issue's description:
> Make webkit_modules a split static library in non-component builds.
> 
> Previously this was force to a source set because it was too large for
official Windows builds to handle as a static library.
> 
> This uses the split_static_library template for non-component official Windows
builds so it can be a static library now.
> 
> BUG=627637
> 
> Committed: https://crrev.com/eb0a50c30fdf3d7ca8f978fb55f363cf1f702b73
> Cr-Commit-Position: refs/heads/master@{#405618}

TBR=brucedawson@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=627637
==========

to

==========
Revert of Make webkit_modules a split static library in non-component builds.
(patchset #2 id:20001 of https://codereview.chromium.org/2145253003/ )

Reason for revert:
I suspect that this change can cause failure in the generate_build_files step on
Windows.

Making a speculative revert to see if the issue is resolved.

See also:

https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chro...

Original issue's description:
> Make webkit_modules a split static library in non-component builds.
> 
> Previously this was force to a source set because it was too large for
official Windows builds to handle as a static library.
> 
> This uses the split_static_library template for non-component official Windows
builds so it can be a static library now.
> 
> BUG=627637
> 
> Committed: https://crrev.com/eb0a50c30fdf3d7ca8f978fb55f363cf1f702b73
> Cr-Commit-Position: refs/heads/master@{#405618}

TBR=brucedawson@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=627637
==========

[commit-bot: I haz the power, 2016-07-15 08:39:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-15 08:40:48]

Description was changed from

==========
Revert of Make webkit_modules a split static library in non-component builds.
(patchset #2 id:20001 of https://codereview.chromium.org/2145253003/ )

Reason for revert:
I suspect that this change can cause failure in the generate_build_files step on
Windows.

Making a speculative revert to see if the issue is resolved.

See also:

https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chro...

Original issue's description:
> Make webkit_modules a split static library in non-component builds.
> 
> Previously this was force to a source set because it was too large for
official Windows builds to handle as a static library.
> 
> This uses the split_static_library template for non-component official Windows
builds so it can be a static library now.
> 
> BUG=627637
> 
> Committed: https://crrev.com/eb0a50c30fdf3d7ca8f978fb55f363cf1f702b73
> Cr-Commit-Position: refs/heads/master@{#405618}

TBR=brucedawson@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=627637
==========

to

==========
Revert of Make webkit_modules a split static library in non-component builds.
(patchset #2 id:20001 of https://codereview.chromium.org/2145253003/ )

Reason for revert:
I suspect that this change can cause failure in the generate_build_files step on
Windows.

Making a speculative revert to see if the issue is resolved.

See also:

https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chro...

Original issue's description:
> Make webkit_modules a split static library in non-component builds.
>
> Previously this was force to a source set because it was too large for
official Windows builds to handle as a static library.
>
> This uses the split_static_library template for non-component official Windows
builds so it can be a static library now.
>
> BUG=627637
>
> Committed: https://crrev.com/eb0a50c30fdf3d7ca8f978fb55f363cf1f702b73
> Cr-Commit-Position: refs/heads/master@{#405618}

TBR=brucedawson@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=627637

Committed: https://crrev.com/52116563313f1ebe1e2b966b429d217442e3362b
Cr-Commit-Position: refs/heads/master@{#405726}
==========

[commit-bot: I haz the power, 2016-07-15 08:40:48]

Patchset 1 (id:??) landed as
https://crrev.com/52116563313f1ebe1e2b966b429d217442e3362b
Cr-Commit-Position: refs/heads/master@{#405726}

[henrika (OOO until Aug 14), 2016-07-15 08:40:57]

The reported issue is given by:

"C:\b\build\slave\google-chrome-rel-win\build\src\buildtools\win\gn.exe gen
//out/Release --check
  -> returned 1
ERROR at //build/split_static_library.gni:27:7: Duplicate output file.
      static_library(current_name) {
      ^-----------------------------
Two or more targets generate the same output:
  obj/third_party/WebKit/Source/modules/blink_modules.lib

This is can often be fixed by changing one of the target names, or by 
setting an output_name on one of them."

and I can only identify this CL as one that can cause it.

Will revert my revert if the bot does not cycle green.

[henrika (OOO until Aug 14), 2016-07-15 10:13:46]

Bots are now green again.

[brettw, 2016-07-15 17:02:21]

Thanks, I see the issue.