Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2150003002: Recognize WEBGL extensions on Firefox (copy with regenerated files) (Closed)

Created:
4 years, 5 months ago by Alan Knight
Modified:
4 years, 5 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Recognize WEBGL extensions on Firefox (copy with regenerated files) Both of the following objects need to map to Dart type 'AngleInstancedArrays' [object ANGLEInstancedArrays] [object ANGLE_instanced_arrays] Fixes https://github.com/dart-lang/sdk/issues/26850 BUG= patch from issue 2147093002 at patchset 1 (http://crrev.com/2147093002#ps1) R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/b9316f9882b02f5adc0df8c904210a0b64b9f756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -24 lines) Patch
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 22 chunks +22 lines, -22 lines 0 comments Download
M tests/html/html.status View 1 chunk +4 lines, -0 lines 0 comments Download
A tests/html/webgl_extensions_test.dart View 1 chunk +199 lines, -0 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +35 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Alan Knight
From https://codereview.chromium.org/2147093002/ , but I've regenerated the libraries.
4 years, 5 months ago (2016-07-14 17:51:32 UTC) #2
sra1
lgtm
4 years, 5 months ago (2016-07-15 19:42:42 UTC) #3
Alan Knight
4 years, 5 months ago (2016-07-15 19:48:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b9316f9882b02f5adc0df8c904210a0b64b9f756 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698