Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/intermediate_language_dbc.cc

Issue 2149993006: DBC: Make unoptimized static calls call through ICData (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/intermediate_language.cc ('K') | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/isolate_reload.cc » ('j') | runtime/vm/isolate_reload.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_dbc.cc
diff --git a/runtime/vm/intermediate_language_dbc.cc b/runtime/vm/intermediate_language_dbc.cc
index aa1259b3a3edeea517246b275dd2014d24ec19c5..eb959f12d57ba251714d1f89395cc3011835f340 100644
--- a/runtime/vm/intermediate_language_dbc.cc
+++ b/runtime/vm/intermediate_language_dbc.cc
@@ -400,7 +400,7 @@ EMIT_NATIVE_CODE(ClosureCall,
compiler->assembler()->AddConstant(arguments_descriptor);
__ StaticCall(argument_count, argdesc_kidx);
compiler->RecordAfterCall(this);
-
+ __ Nop(__ AddConstant(ICData::Handle()));
Vyacheslav Egorov (Google) 2016/07/18 13:52:46 Why it is done this way and not through OptimizedS
zra 2016/07/18 17:38:47 Done.
if (compiler->is_optimizing()) {
__ PopLocal(locs()->out(0).reg());
}
@@ -702,7 +702,7 @@ EMIT_NATIVE_CODE(StringInterpolate,
const intptr_t argdesc_kidx = __ AddConstant(arguments_descriptor);
__ StaticCall(kArgumentCount, argdesc_kidx);
compiler->RecordAfterCall(this);
-
+ __ Nop(__ AddConstant(ICData::Handle()));
Vyacheslav Egorov (Google) 2016/07/18 13:52:46 Ditto.
zra 2016/07/18 17:38:47 Done.
if (compiler->is_optimizing()) {
__ PopLocal(locs()->out(0).reg());
}
« runtime/vm/intermediate_language.cc ('K') | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/isolate_reload.cc » ('j') | runtime/vm/isolate_reload.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698