DBC: Make unoptimized static calls call through ICData

DBC: Make unoptimized static calls call through ICData

Isolate reloading works by manipulating ICData. Unoptimized
static calls won't go to the new function after a reload unless
the calls go through the ICData.

R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/43e89ccdd31db8b3a45bba246394a6ab6b4536e0

[zra, 2016-07-16 05:29:47]

Description was changed from

==========
DBC: Make unoptimized static calls call through IC Data
==========

to

==========
DBC: Make unoptimized static calls call through ICData

Isolate reloading works by manipulating ICData. Unoptimized
static calls won't go to the new function after a reload unless
the calls go through the ICData.
==========

[zra, 2016-07-16 05:31:57]

zra@google.com changed reviewers:
+ vegorov@google.com

[zra, 2016-07-16 05:31:58]

I've made the tests pass, but I'm not sure if this is the best way to structure
this.

[Cutch, 2016-07-18 13:40:02]

johnmccutchan@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-07-18 13:40:03]

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/isolate_reload.cc
File runtime/vm/isolate_reload.cc (right):

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/isolate_reload.c...
runtime/vm/isolate_reload.cc:913: TIR_Print("Marking %s for recompilation,
clearning code\n",
DBC:

Use VTIR_Print here (V == verbose)

[Vyacheslav Egorov (Google), 2016-07-18 13:52:46]

lgtm

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language.cc:3325: __ PushConstant(function());
Maybe instead of pushing function() push ic_data here for unoptimized call? 

I would rename OptimizedStaticCall to StaticCall and StaticCall to
IndirectStaticCall.

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_dbc.cc (right):

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_dbc.cc:403: __ Nop(__
AddConstant(ICData::Handle()));
Why it is done this way and not through OptimizedStaticCall?

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_dbc.cc:705: __ Nop(__
AddConstant(ICData::Handle()));
Ditto.

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/simulator_dbc.cc
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/simulator_dbc.cc...
runtime/vm/simulator_dbc.cc:1389: RawObject* ic_data_obj =
LOAD_CONSTANT(Bytecode::DecodeD(*pc));
pc++ to skip NOP?

[zra, 2016-07-18 17:38:48]

Thanks!

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language.cc:3325: __ PushConstant(function());
On 2016/07/18 13:52:46, Vyacheslav Egorov (Google) wrote:
> Maybe instead of pushing function() push ic_data here for unoptimized call? 
> 
> I would rename OptimizedStaticCall to StaticCall and StaticCall to
> IndirectStaticCall.

Done.

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_dbc.cc (right):

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_dbc.cc:403: __ Nop(__
AddConstant(ICData::Handle()));
On 2016/07/18 13:52:46, Vyacheslav Egorov (Google) wrote:
> Why it is done this way and not through OptimizedStaticCall?

Done.

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_dbc.cc:705: __ Nop(__
AddConstant(ICData::Handle()));
On 2016/07/18 13:52:46, Vyacheslav Egorov (Google) wrote:
> Ditto.

Done.

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/isolate_reload.cc
File runtime/vm/isolate_reload.cc (right):

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/isolate_reload.c...
runtime/vm/isolate_reload.cc:913: TIR_Print("Marking %s for recompilation,
clearning code\n",
On 2016/07/18 13:40:03, Cutch wrote:
> DBC:
> 
> Use VTIR_Print here (V == verbose)

Done.

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/simulator_dbc.cc
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2149993006/diff/1/runtime/vm/simulator_dbc.cc...
runtime/vm/simulator_dbc.cc:1389: RawObject* ic_data_obj =
LOAD_CONSTANT(Bytecode::DecodeD(*pc));
On 2016/07/18 13:52:46, Vyacheslav Egorov (Google) wrote:
> pc++ to skip NOP?

No more NOP after other changes.

[zra, 2016-07-18 17:39:12]

Description was changed from

==========
DBC: Make unoptimized static calls call through ICData

Isolate reloading works by manipulating ICData. Unoptimized
static calls won't go to the new function after a reload unless
the calls go through the ICData.
==========

to

==========
DBC: Make unoptimized static calls call through ICData

Isolate reloading works by manipulating ICData. Unoptimized
static calls won't go to the new function after a reload unless
the calls go through the ICData.

R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/43e89ccdd31db8b3a45bba246394a6ab6b4536e0
==========

[zra, 2016-07-18 17:39:14]

Committed patchset #2 (id:20001) manually as
43e89ccdd31db8b3a45bba246394a6ab6b4536e0 (presubmit successful).