Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2149973002: Remove embeddedSearch.searchBox.displayInstantResults (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 4 months ago
Reviewers:
Jered, nasko
CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, chromium-apps-reviews_chromium.org, kmadhusu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@searchbox_applauncher
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove embeddedSearch.searchBox.displayInstantResults and all the related IPC code It's not used anywhere, and it's not documented at http://dev.chromium.org/embeddedsearch BUG=628207 Committed: https://crrev.com/3ae19e4141a44e52e3b5877611b8be686a16a1a6 Cr-Commit-Position: refs/heads/master@{#407849}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -136 lines) Patch
M chrome/browser/ui/search/search_ipc_router.h View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_policy_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/search/search_ipc_router_policy_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_policy_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_unittest.cc View 3 chunks +0 lines, -65 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/render_messages.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/searchbox_api.js View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 3 chunks +0 lines, -20 lines 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.unit_tests.filter View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Marc Treib
One more - PTAL! I've checked that this isn't used, neither in Chromium nor server-side ...
4 years, 4 months ago (2016-07-26 08:47:22 UTC) #3
Jered
On 2016/07/26 08:47:22, Marc Treib wrote: > One more - PTAL! > I've checked that ...
4 years, 4 months ago (2016-07-26 14:08:53 UTC) #4
Marc Treib
+nasko for render_messages.h. PTAL!
4 years, 4 months ago (2016-07-26 14:16:57 UTC) #6
nasko
IPC LGTM
4 years, 4 months ago (2016-07-26 15:36:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149973002/20001
4 years, 4 months ago (2016-07-26 16:34:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 17:57:50 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 17:59:30 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3ae19e4141a44e52e3b5877611b8be686a16a1a6
Cr-Commit-Position: refs/heads/master@{#407849}

Powered by Google App Engine
This is Rietveld 408576698