Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: third_party/WebKit/LayoutTests/fast/table/change-col-border-width.html

Issue 2149953004: [css-tables] Set needsLayout on cells when column border width changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/table/change-col-border-width.html
diff --git a/third_party/WebKit/LayoutTests/fast/table/change-tbody-border-width.html b/third_party/WebKit/LayoutTests/fast/table/change-col-border-width.html
similarity index 61%
copy from third_party/WebKit/LayoutTests/fast/table/change-tbody-border-width.html
copy to third_party/WebKit/LayoutTests/fast/table/change-col-border-width.html
index 6760bc588672080ccd44def486f9d5f0410e123a..7866ae066077586bc862dd6b4f682800a29f725b 100644
--- a/third_party/WebKit/LayoutTests/fast/table/change-tbody-border-width.html
+++ b/third_party/WebKit/LayoutTests/fast/table/change-col-border-width.html
@@ -9,22 +9,20 @@
<script src="../../resources/check-layout.js"></script>
<script src="../../resources/run-after-layout-and-paint.js"></script>
<script type="text/javascript">
- function shrinkSectionBorder() {
- document.getElementById("section").style.borderWidth = "4px";
+ function shrinkColumnBorder() {
+ theColumn.style.borderWidth = "4px";
checkLayout("div");
}
- runAfterLayoutAndPaint(shrinkSectionBorder, true);
+ runAfterLayoutAndPaint(shrinkColumnBorder, true);
</script>
<p>Changing a collapsed border's width should change the width of the table and the width of a shrink-to-fit containing block.</p>
<p>There should be a square with a 4px inner blue border and a 1px outer black border.</p>
-<p>Firefox 50.0a1 (nightly 2016-07-07) fails this, so it should probably be upstreamed, except it uses chrome-specific `runAfterLayoutAndPaint`.</p>
-<p>The table cell has rowspan=2 because we almost didn't cover the case where a cell's rowspan exceeded the declared rows.</p>
+<p>Firefox 50.0a1 (nightly 2016-07-14) fails this, so it should probably be upstreamed, except it uses chrome-specific `runAfterLayoutAndPaint`.</p>
<div style="float:left; border: 1px solid black" data-expected-width=60>
<table style="border-collapse:collapse" data-expected-width=58 data-expected-height=58>
- <tbody style="border:18px solid lightblue" id="section">
- <tr>
- <td rowspan=2></td>
- </tr>
- </tbody>
+ <col style="border:18px solid lightblue" id="theColumn">
+ <tr>
+ <td></td>
+ </tr>
</table>
</div>

Powered by Google App Engine
This is Rietveld 408576698