Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2149953003: [fuchsia] GN build support for Fuchsia OS and fuchsia_test target (Closed)

Created:
4 years, 5 months ago by jamesr
Modified:
4 years, 5 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/external/github.com/dart-lang/sdk/@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[fuchsia] GN build support for Fuchsia OS and fuchsia_test target This adds a GN target for the 'fuchsia_test' executable and teaches the GN build about is_fuchsia. Key differences: *) There's not currently a dart:io implementation for Fuchsia *) Fuchsia's toolchain currently doesn't support (or need) ldl or lpthread *) Fuchsia's buildconfig doesn't currently set the is_asan variable Committed: https://github.com/dart-lang/sdk/commit/e27b49fc80f434f790875707df9a4b8958e4b2dc

Patch Set 1 #

Total comments: 3

Patch Set 2 : also set TARGET_OS_FUCHSIA #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -9 lines) Patch
M runtime/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/BUILD.gn View 3 chunks +24 lines, -1 line 0 comments Download
M runtime/platform/globals.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/BUILD.gn View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jamesr
https://codereview.chromium.org/2149953003/diff/1/runtime/bin/BUILD.gn File runtime/bin/BUILD.gn (right): https://codereview.chromium.org/2149953003/diff/1/runtime/bin/BUILD.gn#newcode9 runtime/bin/BUILD.gn:9: if (!is_fuchsia) { this is needed since the only ...
4 years, 5 months ago (2016-07-14 19:47:45 UTC) #2
zra
Committed patchset #2 (id:20001) manually as e27b49fc80f434f790875707df9a4b8958e4b2dc (presubmit successful).
4 years, 5 months ago (2016-07-14 22:01:35 UTC) #4
zra
4 years, 5 months ago (2016-07-14 22:02:59 UTC) #5
Message was sent while issue was closed.
lgtm

Had to check for defined(is_fuchsia) in a couple places.

Powered by Google App Engine
This is Rietveld 408576698