Enable login screen apps.

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <iterator>
@@ skipping 87 matching lines @@
 #include "extensions/common/permissions/permission_message_provider.h"
 #include "extensions/common/permissions/permissions_data.h"
 
 #if BUILDFLAG(ENABLE_SUPERVISED_USERS)
 #include "chrome/browser/supervised_user/supervised_user_service.h"
 #include "chrome/browser/supervised_user/supervised_user_service_factory.h"
 #endif
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/extensions/install_limiter.h"
+#include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "storage/browser/fileapi/file_system_backend.h"
 #include "storage/browser/fileapi/file_system_context.h"
 #endif
 
 using content::BrowserContext;
 using content::BrowserThread;
 using content::DevToolsAgentHost;
 using extensions::APIPermission;
 using extensions::AppSorting;
 using extensions::CrxInstaller;
@@ skipping 316 matching lines @@
 void ExtensionService::Init() {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   TRACE_EVENT0("browser,startup", "ExtensionService::Init");
   SCOPED_UMA_HISTOGRAM_TIMER("Extensions.ExtensionServiceInitTime");
 
   DCHECK(!is_ready());  // Can't redo init.
   DCHECK_EQ(registry_->enabled_extensions().size(), 0u);
 
   // LoadAllExtensions() calls OnLoadedInstalledExtensions().
   component_loader_->LoadAll();
-  extensions::InstalledLoader(this).LoadAllExtensions();
+  bool load_saved_extensions = true;
+#if defined(OS_CHROMEOS)
+  if (chromeos::ProfileHelper::IsSigninProfile(profile_))
+    load_saved_extensions = false;
+#endif
+  if (load_saved_extensions)
+    extensions::InstalledLoader(this).LoadAllExtensions();
+  else
+    OnLoadedInstalledExtensions();  // Callback from LoadAllExtensions.

[Devlin, 2017/03/22 22:57:39]

nit: elaborate a bit on this comment. Also, this flow is somewhat silly
(unrelated to this CL) - mind adding a TODO(me) to clean it up?

if (load_saved_extensions) {
  extensions::InstalledLoader(this).LoadAllExtensions();
} else {
  // InstalledLoader::LoadAllExtensions normally calls
OnLoadedInstalledExtensions
  // itself, but here we circumvent that path. Call OnLoadedInstalledExtensions
  // directly.
  // TODO(devlin): LoadInstalledExtensions() is synchronous - we can simplify
  // this.
  OnLoadedInstalledExtensions();
}

[achuithb, 2017/03/23 00:26:26]

Done.

I thought about refactoring this, but I think a follow-up CL would be better.

   LoadExtensionsFromCommandLineFlag(switches::kDisableExtensionsExcept);
   if (extensions_enabled_)
     LoadExtensionsFromCommandLineFlag(switches::kLoadExtension);
   // ChromeDriver has no way of determining the Chrome version until after
   // launch, so it needs to continue passing load-component-extension until it
   // stops supporting Chrome 56 (when M58 is released). These extensions are
   // loaded as regular extensions, not component extensions, and are thus safe.
   // TODO(samuong): Remove this when we release Chrome 58 to stable channel.
   if (command_line_->HasSwitch(switches::kEnableAutomation) &&
       command_line_->HasSwitch(kDeprecatedLoadComponentExtension)) {
@@ skipping 2087 matching lines @@
 }
 
 void ExtensionService::OnProfileDestructionStarted() {
   ExtensionIdSet ids_to_unload = registry_->enabled_extensions().GetIDs();
   for (ExtensionIdSet::iterator it = ids_to_unload.begin();
        it != ids_to_unload.end();
        ++it) {
     UnloadExtension(*it, UnloadedExtensionInfo::REASON_PROFILE_SHUTDOWN);
   }
 }