Enable login screen apps.

chrome/browser/extensions/installed_loader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/installed_loader.h"
 
 #include <stddef.h>
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 24 matching lines @@
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_l10n_util.h"
 #include "extensions/common/extension_set.h"
 #include "extensions/common/extension_urls.h"
 #include "extensions/common/file_util.h"
 #include "extensions/common/manifest.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/manifest_handlers/background_info.h"
 #include "extensions/common/manifest_url_handlers.h"
 
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/profiles/profile_helper.h"
+#endif
+
 using base::UserMetricsAction;
 using content::BrowserThread;
 
 namespace extensions {
 
 namespace errors = manifest_errors;
 
 namespace {
 
 // The following enumeration is used in histograms matching
@@ skipping 245 matching lines @@
       }
 
       extensions_info->at(i)->extension_manifest.reset(
           static_cast<base::DictionaryValue*>(
               extension->manifest()->value()->DeepCopy()));
       should_write_prefs = true;
     }
   }
 
   for (size_t i = 0; i < extensions_info->size(); ++i) {
-    if (extensions_info->at(i)->extension_location != Manifest::COMMAND_LINE)
+    // Don't load saved extensions from the command line.
+    bool should_load =
+        extensions_info->at(i)->extension_location != Manifest::COMMAND_LINE;
+#if defined(OS_CHROMEOS)
+    // Also don't load saved extensions in the signin profile.
+    if (chromeos::ProfileHelper::IsSigninProfile(profile))

[Devlin, 2017/03/17 16:37:23]

We should just early out of this whole function, or not call it in the first
place.  The only point is to load extensions from prefs, so if we're not doing
that, there's nothing to do.

[achuithb, 2017/03/22 00:15:53]

Done.

+      should_load = false;
+#endif
+    if (should_load)
       Load(*extensions_info->at(i), should_write_prefs);
   }
 
   extension_service_->OnLoadedInstalledExtensions();
 
   // The histograms Extensions.ManifestReload* allow us to validate
   // the assumption that reloading manifest is a rare event.
   UMA_HISTOGRAM_COUNTS_100("Extensions.ManifestReloadNotNeeded",
                            reload_reason_counts[NOT_NEEDED]);
   UMA_HISTOGRAM_COUNTS_100("Extensions.ManifestReloadUnpackedDir",
@@ skipping 305 matching lines @@
 int InstalledLoader::GetCreationFlags(const ExtensionInfo* info) {
   int flags = extension_prefs_->GetCreationFlags(info->extension_id);
   if (!Manifest::IsUnpackedLocation(info->extension_location))
     flags |= Extension::REQUIRE_KEY;
   if (extension_prefs_->AllowFileAccess(info->extension_id))
     flags |= Extension::ALLOW_FILE_ACCESS;
   return flags;
 }
 
 }  // namespace extensions