Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2149943002: Improve handling of invalid frame ID in MSDH::OnCancelDeviceChangeNotifications (Closed)

Created:
4 years, 5 months ago by Guido Urdaneta
Modified:
4 years, 5 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve handling of invalid frame ID in MSDH::OnCancelDeviceChangeNotifications Use bad_message::ReceivedBadMessage() to handle an invalid frame ID passed via IPC. BUG=624447, 627436 Committed: https://crrev.com/a1cf8423d5032e9fc3d463ca7f36f9e282d2d29d Cr-Commit-Position: refs/heads/master@{#405663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M content/browser/bad_message.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 2 chunks +5 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Guido Urdaneta
holte@chromium.org: Please review changes in histogram.xml jochen@chromium.org: Please review changes in content/browser
4 years, 5 months ago (2016-07-14 12:37:43 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-14 15:04:28 UTC) #3
Steven Holte
lgtm
4 years, 5 months ago (2016-07-14 21:38:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149943002/1
4 years, 5 months ago (2016-07-15 00:12:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 01:24:09 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 01:24:23 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 01:25:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1cf8423d5032e9fc3d463ca7f36f9e282d2d29d
Cr-Commit-Position: refs/heads/master@{#405663}

Powered by Google App Engine
This is Rietveld 408576698