Pre-work for adding usage counter for chrome.loadtimes

chrome/renderer/loadtimes_extension_bindings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/loadtimes_extension_bindings.h"
 
 #include <math.h>
 
 #include "base/time/time.h"
 #include "content/public/renderer/document_state.h"
+#include "extensions/renderer/v8_helpers.h"
 #include "net/http/http_response_info.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebPerformance.h"
 #include "v8/include/v8.h"
 
 using blink::WebDataSource;
 using blink::WebLocalFrame;
 using blink::WebNavigationType;
 using blink::WebPerformance;
 using content::DocumentState;
@@ skipping 77 matching lines @@
       case blink::WebNavigationTypeBackForward:
         return kTransitionForwardBack;
       case blink::WebNavigationTypeReload:
         return kTransitionReload;
       case blink::WebNavigationTypeOther:
         return kTransitionOther;
     }
     return kTransitionOther;
   }
 
+  static void TestLoadtimesGetter(
+      v8::Local<v8::Name> name,
+      const v8::PropertyCallbackInfo<v8::Value>& info) {
+    v8::Local<v8::Object> param = v8::Local<v8::Object>::Cast(info.Data());

[adamk, 2016/07/14 22:09:03]

Object here is the wrong type (since you might have a Number or a String), I
think you just want to do:

info.GetReturnValue().Set(info.Data())

to just return it as a Value directly.

+    info.GetReturnValue().Set(param);
+  }
+
   static void GetLoadTimes(const v8::FunctionCallbackInfo<v8::Value>& args) {
     args.GetReturnValue().SetNull();
     WebLocalFrame* frame = WebLocalFrame::frameForCurrentContext();
     if (!frame) {
       return;
     }
     WebDataSource* data_source = frame->dataSource();
     if (!data_source) {
       return;
     }
@@ skipping 45 matching lines @@
     bool was_alternate_protocol_available =
         document_state->was_alternate_protocol_available();
     std::string connection_info = net::HttpResponseInfo::ConnectionInfoToString(
         document_state->connection_info());
     // Important: |frame|, |data_source| and |document_state| should not be
     // referred to below this line, as JS setters below can invalidate these
     // pointers.
     v8::Isolate* isolate = args.GetIsolate();
     v8::Local<v8::Context> ctx = isolate->GetCurrentContext();
     v8::Local<v8::Object> load_times = v8::Object::New(isolate);
+
     if (!load_times
-             ->Set(ctx, v8::String::NewFromUtf8(isolate, "requestTime",
-                                                v8::NewStringType::kNormal)
-                            .ToLocalChecked(),
-                   v8::Number::New(isolate, request_time))
+        ->SetAccessor(
+            ctx,
+            extensions::v8_helpers::ToV8StringUnsafe(
+                isolate, "requestTime", v8::NewStringType::kNormal),
+            TestLoadtimesGetter,
+            nullptr,
+            v8::Number::New(isolate, request_time))
              .FromMaybe(false)) {
       return;
     }
 
     if (!load_times
              ->Set(ctx, v8::String::NewFromUtf8(isolate, "startLoadTime",
                                                 v8::NewStringType::kNormal)
                             .ToLocalChecked(),
                    v8::Number::New(isolate, start_load_time))
              .FromMaybe(false)) {
@@ skipping 158 matching lines @@
     }
     args.GetReturnValue().Set(csi);
   }
 };
 
 v8::Extension* LoadTimesExtension::Get() {
   return new LoadTimesExtensionWrapper();
 }
 
 }  // namespace extensions_v8