third_party/WebKit/Source/core/editing/VisibleUnits.cpp - Issue 2149913003: Make previousLinePosition() not to use dangling RootInlineBox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 2149913003: Make previousLinePosition() not to use dangling RootInlineBox (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

index aec898d9c92a4d1b74c5b09caea386ff71312cb7..b59948bc465248c5ac7f2da6a2c66f51cd0c79b4 100644

--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp

@@ -1328,7 +1328,7 @@ VisiblePosition previousLinePosition(const VisiblePosition& visiblePosition, Lay

if (root) {

// FIXME: Can be wrong for multi-column layout and with transforms.

LayoutPoint pointInLine = absoluteLineDirectionPointToLocalPointInBlock(root, lineDirectionPoint);

- LineLayoutItem lineLayoutItem = root->closestLeafChildForPoint(pointInLine, isEditablePosition(p))->getLineLayoutItem();

+ LineLayoutItem lineLayoutItem = root->closestLeafChildForPoint(pointInLine, isEditablePosition(p, ContentIsEditable, DoNotUpdateStyle))->getLineLayoutItem();

Node* node = lineLayoutItem.node();

if (node && editingIgnoresContent(node))

return createVisiblePosition(Position::inParentBeforeNode(*node));

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/selection/modify_move/move_backward_line_import_crash.html ('k') | no next file » | no next file with comments »