core/fxge/dib/fx_dib_transform.cpp - Issue 2149903002: Use smart pointers for various Jbig2 decoding contexts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxge/dib/fx_dib_transform.cpp

Issue 2149903002: Use smart pointers for various Jbig2 decoding contexts (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxge/dib/fx_dib_transform.cpp

diff --git a/core/fxge/dib/fx_dib_transform.cpp b/core/fxge/dib/fx_dib_transform.cpp

index 82b9cf781f49448b2f527bf5810423024afcdf64..d997a8fa797f7bafd07c2a56c567748b57033320 100644

--- a/core/fxge/dib/fx_dib_transform.cpp

+++ b/core/fxge/dib/fx_dib_transform.cpp

@@ -190,7 +190,7 @@ CFX_DIBitmap* CFX_DIBSource::SwapXY(FX_BOOL bXFlip,

delete pTransBitmap;

return nullptr;

}

- pTransBitmap->CopyPalette(m_pPalette);

+ pTransBitmap->CopyPalette(m_pPalette.get());

int dest_pitch = pTransBitmap->GetPitch();

uint8_t* dest_buf = pTransBitmap->GetBuffer();

int row_start = bXFlip ? m_Height - dest_clip.right : dest_clip.left;