Use smart pointers for various Jbig2 decoding contexts

Use smart pointers for various Jbig2 decoding contexts

Use unique_ptr for class owned member variables, and remove unnecessary
or unused functions and member variable.

BUG=pdfium:518
Committed: https://pdfium.googlesource.com/pdfium/+/8ca60b2cda3efc112c987c1d57d1eb8568667da9

[Wei Li, 2016-07-14 19:10:54]

Patchset #2 (id:20001) has been deleted

[Wei Li, 2016-07-14 19:11:05]

Patchset #2 (id:40001) has been deleted

[Wei Li, 2016-07-15 17:38:26]

weili@chromium.org changed reviewers:
+ thestig@chromium.org

[Wei Li, 2016-07-15 17:38:27]

pls review, thanks

[Lei Zhang, 2016-07-16 01:30:38]

https://codereview.chromium.org/2149903002/diff/60001/core/fxcodec/jbig2/JBig...
File core/fxcodec/jbig2/JBig2_Context.h (right):

https://codereview.chromium.org/2149903002/diff/60001/core/fxcodec/jbig2/JBig...
core/fxcodec/jbig2/JBig2_Context.h:100: std::unique_ptr<JBig2ArithCtx,
FxFreeDeleter> m_gbContext;
vector?

https://codereview.chromium.org/2149903002/diff/60001/core/fxge/include/fx_dib.h
File core/fxge/include/fx_dib.h (right):

https://codereview.chromium.org/2149903002/diff/60001/core/fxge/include/fx_di...
core/fxge/include/fx_dib.h:268: std::unique_ptr<uint32_t, FxFreeDeleter>
m_pPalette;
Can we work on this in a separate CL and convert it to a vector?

[Wei Li, 2016-07-18 21:08:42]

ptal, thanks

[Wei Li, 2016-07-18 21:29:35]

forgot to reply

https://codereview.chromium.org/2149903002/diff/60001/core/fxcodec/jbig2/JBig...
File core/fxcodec/jbig2/JBig2_Context.h (right):

https://codereview.chromium.org/2149903002/diff/60001/core/fxcodec/jbig2/JBig...
core/fxcodec/jbig2/JBig2_Context.h:100: std::unique_ptr<JBig2ArithCtx,
FxFreeDeleter> m_gbContext;
On 2016/07/16 01:30:38, Lei Zhang wrote:
> vector?

Done.

https://codereview.chromium.org/2149903002/diff/60001/core/fxge/include/fx_dib.h
File core/fxge/include/fx_dib.h (right):

https://codereview.chromium.org/2149903002/diff/60001/core/fxge/include/fx_di...
core/fxge/include/fx_dib.h:268: std::unique_ptr<uint32_t, FxFreeDeleter>
m_pPalette;
On 2016/07/16 01:30:38, Lei Zhang wrote:
> Can we work on this in a separate CL and convert it to a vector?

Sure.

[Lei Zhang, 2016-07-18 23:55:10]

lgtm

https://codereview.chromium.org/2149903002/diff/100001/core/fxcodec/jbig2/JBi...
File core/fxcodec/jbig2/JBig2_Context.cpp (right):

https://codereview.chromium.org/2149903002/diff/100001/core/fxcodec/jbig2/JBi...
core/fxcodec/jbig2/JBig2_Context.cpp:1087: if (!m_gbContext.size()) {
if (m_gbContext.empty())

https://codereview.chromium.org/2149903002/diff/100001/core/fxge/dib/fx_dib_c...
File core/fxge/dib/fx_dib_convert.cpp (right):

https://codereview.chromium.org/2149903002/diff/100001/core/fxge/dib/fx_dib_c...
core/fxge/dib/fx_dib_convert.cpp:889: m_pPalette.reset(pal_8bpp.release());
std::move?

https://codereview.chromium.org/2149903002/diff/100001/core/fxge/dib/fx_dib_m...
File core/fxge/dib/fx_dib_main.cpp (right):

https://codereview.chromium.org/2149903002/diff/100001/core/fxge/dib/fx_dib_m...
core/fxge/dib/fx_dib_main.cpp:577: if (pal_size > kPaletteSize)
pal_size = std::min(pal_size, kPalletSize);

https://codereview.chromium.org/2149903002/diff/100001/core/fxge/dib/fx_dib_m...
core/fxge/dib/fx_dib_main.cpp:933: int r = (uint8_t)(m_pPalette.get()[i] >> 16);
get rid of the C-style cast while we are here?

https://codereview.chromium.org/2149903002/diff/100001/core/fxge/dib/fx_dib_m...
core/fxge/dib/fx_dib_main.cpp:964: int r = (uint8_t)(m_pPalette.get()[i] >> 16);
Ditto

[Wei Li, 2016-07-19 21:21:29]

thanks

https://codereview.chromium.org/2149903002/diff/100001/core/fxcodec/jbig2/JBi...
File core/fxcodec/jbig2/JBig2_Context.cpp (right):

https://codereview.chromium.org/2149903002/diff/100001/core/fxcodec/jbig2/JBi...
core/fxcodec/jbig2/JBig2_Context.cpp:1087: if (!m_gbContext.size()) {
On 2016/07/18 23:55:10, Lei Zhang wrote:
> if (m_gbContext.empty())

Done.

https://codereview.chromium.org/2149903002/diff/100001/core/fxge/dib/fx_dib_c...
File core/fxge/dib/fx_dib_convert.cpp (right):

https://codereview.chromium.org/2149903002/diff/100001/core/fxge/dib/fx_dib_c...
core/fxge/dib/fx_dib_convert.cpp:889: m_pPalette.reset(pal_8bpp.release());
On 2016/07/18 23:55:10, Lei Zhang wrote:
> std::move?

Done.

https://codereview.chromium.org/2149903002/diff/100001/core/fxge/dib/fx_dib_m...
File core/fxge/dib/fx_dib_main.cpp (right):

https://codereview.chromium.org/2149903002/diff/100001/core/fxge/dib/fx_dib_m...
core/fxge/dib/fx_dib_main.cpp:577: if (pal_size > kPaletteSize)
On 2016/07/18 23:55:10, Lei Zhang wrote:
> pal_size = std::min(pal_size, kPalletSize);

Done.

https://codereview.chromium.org/2149903002/diff/100001/core/fxge/dib/fx_dib_m...
core/fxge/dib/fx_dib_main.cpp:933: int r = (uint8_t)(m_pPalette.get()[i] >> 16);
On 2016/07/18 23:55:10, Lei Zhang wrote:
> get rid of the C-style cast while we are here?

Done.

https://codereview.chromium.org/2149903002/diff/100001/core/fxge/dib/fx_dib_m...
core/fxge/dib/fx_dib_main.cpp:964: int r = (uint8_t)(m_pPalette.get()[i] >> 16);
On 2016/07/18 23:55:10, Lei Zhang wrote:
> Ditto

Done.

[Wei Li, 2016-07-19 22:52:30]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-07-19 22:52:30]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2149903002/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-19 22:52:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-07-19 22:57:26]

https://codereview.chromium.org/2149903002/diff/120001/core/fxge/dib/fx_dib_m...
File core/fxge/dib/fx_dib_main.cpp (right):

https://codereview.chromium.org/2149903002/diff/120001/core/fxge/dib/fx_dib_m...
core/fxge/dib/fx_dib_main.cpp:9: #include <algorithm>
C++ headers after C headers.

[commit-bot: I haz the power, 2016-07-19 23:06:26]

Description was changed from

==========
Use smart pointers for various Jbig2 decoding contexts

Use unique_ptr for class owned member variables, and remove unnecessary
or unused functions and member variable.

BUG=pdfium:518
==========

to

==========
Use smart pointers for various Jbig2 decoding contexts

Use unique_ptr for class owned member variables, and remove unnecessary
or unused functions and member variable.

BUG=pdfium:518

Committed:
https://pdfium.googlesource.com/pdfium/+/8ca60b2cda3efc112c987c1d57d1eb856866...
==========

[commit-bot: I haz the power, 2016-07-19 23:06:27]

Committed patchset #6 (id:140001) as
https://pdfium.googlesource.com/pdfium/+/8ca60b2cda3efc112c987c1d57d1eb856866...

[commit-bot: I haz the power, 2016-07-19 23:06:29]

CQ bit was unchecked.

[Wei Li, 2016-07-19 23:39:41]

https://codereview.chromium.org/2149903002/diff/120001/core/fxge/dib/fx_dib_m...
File core/fxge/dib/fx_dib_main.cpp (right):

https://codereview.chromium.org/2149903002/diff/120001/core/fxge/dib/fx_dib_m...
core/fxge/dib/fx_dib_main.cpp:9: #include <algorithm>
On 2016/07/19 22:57:26, Lei Zhang wrote:
> C++ headers after C headers.

Will fix this style in next CL, thanks

[Lei Zhang, 2016-07-19 23:41:27]

On 2016/07/19 23:39:41, Wei Li wrote:
>
https://codereview.chromium.org/2149903002/diff/120001/core/fxge/dib/fx_dib_m...
> File core/fxge/dib/fx_dib_main.cpp (right):
> 
>
https://codereview.chromium.org/2149903002/diff/120001/core/fxge/dib/fx_dib_m...
> core/fxge/dib/fx_dib_main.cpp:9: #include <algorithm>
> On 2016/07/19 22:57:26, Lei Zhang wrote:
> > C++ headers after C headers.
> 
> Will fix this style in next CL, thanks

No worries, thanks.