editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/LibraryImportScopeTest.java - Issue 21499005: Issue 12106. Ambiguous import is now always static warning, never error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/LibraryImportScopeTest.java

Issue 21499005: Issue 12106. Ambiguous import is now always static warning, never error. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/LibraryImportScope.java ('k') | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/LibraryImportScopeTest.java

diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/LibraryImportScopeTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/LibraryImportScopeTest.java

index b9aa8ed46b3076137bd9d4f42e58ad3f6f670dcf..73bc57500f20fad69867831168614960e2cf212e 100644

--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/LibraryImportScopeTest.java

+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/scope/LibraryImportScopeTest.java

@@ -20,7 +20,6 @@ import com.google.dart.engine.element.Element;

import com.google.dart.engine.element.ImportElement;

import com.google.dart.engine.element.LibraryElement;

import com.google.dart.engine.element.MultiplyDefinedElement;

-import com.google.dart.engine.error.CompileTimeErrorCode;

import com.google.dart.engine.error.GatheringErrorListener;

import com.google.dart.engine.error.StaticWarningCode;

import com.google.dart.engine.internal.context.AnalysisContextImpl;

@@ -71,7 +70,7 @@ public class LibraryImportScopeTest extends ResolverTestCase {

errorListener.assertNoErrors();

Element element = scope.lookup(identifier(typeNameB), importingLibrary);

- errorListener.assertErrors(CompileTimeErrorCode.AMBIGUOUS_IMPORT);

+ errorListener.assertErrors(StaticWarningCode.AMBIGUOUS_IMPORT);

assertInstanceOf(MultiplyDefinedElement.class, element);

Element[] conflictingElements = ((MultiplyDefinedElement) element).getConflictingElements();