Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 21499003: Move helper methods from i18n extension into runtime. (Closed)

Created:
7 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Move helper methods from i18n extension into runtime. BUG=v8:2475 R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16015

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -333 lines) Patch
M src/extensions/i18n/i18n-extension.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M src/extensions/i18n/i18n-utils.js View 4 chunks +3 lines, -8 lines 0 comments Download
D src/extensions/i18n/locale.h View 1 chunk +0 lines, -56 lines 0 comments Download
D src/extensions/i18n/locale.cc View 1 chunk +0 lines, -251 lines 0 comments Download
M src/extensions/i18n/locale.js View 2 chunks +1 line, -3 lines 0 comments Download
M src/runtime.h View 2 chunks +17 lines, -1 line 0 comments Download
M src/runtime.cc View 2 chunks +197 lines, -0 lines 4 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-01 09:12:09 UTC) #1
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-01 09:12:27 UTC) #2
dcarney
lgtm maybe the i18n runtime functions want their own file if they are behind a ...
7 years, 4 months ago (2013-08-01 09:21:39 UTC) #3
jochen (gone - plz use gerrit)
On 2013/08/01 09:21:39, dcarney wrote: > lgtm > > maybe the i18n runtime functions want ...
7 years, 4 months ago (2013-08-01 09:22:51 UTC) #4
Michael Starzinger
LGTM (with nits). I didn't actually review the implementation of the runtime methods, but I ...
7 years, 4 months ago (2013-08-01 09:58:20 UTC) #5
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-01 19:25:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r16015 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698