Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Unified Diff: chrome/browser/notifications/notification_permission_context.h

Issue 2149883002: Use the same codepath for NOTIFICATIONS and PUSH_MESSAGING permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/notifications/notification_permission_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/notification_permission_context.h
diff --git a/chrome/browser/notifications/notification_permission_context.h b/chrome/browser/notifications/notification_permission_context.h
index 5b92b3d48a80913962bd8ea815c21ed5bbc00dc3..06053da24f9f3fe1087ac0695dae8ad1b814b412 100644
--- a/chrome/browser/notifications/notification_permission_context.h
+++ b/chrome/browser/notifications/notification_permission_context.h
@@ -14,20 +14,21 @@ class Profile;
class NotificationPermissionContext : public PermissionContextBase {
public:
- explicit NotificationPermissionContext(Profile* profile);
+ NotificationPermissionContext(Profile* profile,
+ content::PermissionType permission_type);
~NotificationPermissionContext() override;
// PermissionContextBase implementation.
+ ContentSetting GetPermissionStatus(
+ const GURL& requesting_origin,
+ const GURL& embedding_origin) const override;
void ResetPermission(const GURL& requesting_origin,
const GURL& embedder_origin) override;
void CancelPermissionRequest(content::WebContents* web_contents,
const PermissionRequestID& id) override;
private:
- FRIEND_TEST_ALL_PREFIXES(NotificationPermissionContextTest,
- IgnoresEmbedderOrigin);
- FRIEND_TEST_ALL_PREFIXES(NotificationPermissionContextTest,
- NoSecureOriginRequirement);
+ friend class NotificationPermissionContextTest;
// PermissionContextBase implementation.
void DecidePermission(content::WebContents* web_contents,
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/notifications/notification_permission_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698