chrome/browser/notifications/notification_permission_context_unittest.cc - Issue 2149883002: Use the same codepath for NOTIFICATIONS and PUSH_MESSAGING permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_permission_context_unittest.cc

Issue 2149883002: Use the same codepath for NOTIFICATIONS and PUSH_MESSAGING permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/notification_permission_context.cc ('K') | « chrome/browser/notifications/notification_permission_context.cc ('k') | chrome/browser/permissions/permission_manager.cc » ('j') | chrome/browser/push_messaging/push_messaging_permission_context.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_permission_context_unittest.cc

diff --git a/chrome/browser/notifications/notification_permission_context_unittest.cc b/chrome/browser/notifications/notification_permission_context_unittest.cc

index 0aa58db82cbea7f4f891a9f2ed41715513390e6c..122fe65a237cd5b08b56a22c8e8bb5a7b8e9b166 100644

--- a/chrome/browser/notifications/notification_permission_context_unittest.cc

+++ b/chrome/browser/notifications/notification_permission_context_unittest.cc

@@ -34,7 +34,8 @@ void DoNothing2(blink::mojom::PermissionStatus status) {}

class TestNotificationPermissionContext : public NotificationPermissionContext {

public:

explicit TestNotificationPermissionContext(Profile* profile)

- : NotificationPermissionContext(profile),

+ : NotificationPermissionContext(profile,

+ content::PermissionType::NOTIFICATIONS),

permission_set_count_(0),

last_permission_set_persisted_(false),

last_permission_set_setting_(CONTENT_SETTING_DEFAULT) {}

@@ -108,7 +109,8 @@ TEST_F(NotificationPermissionContextTest, IgnoresEmbedderOrigin) {

GURL embedding_origin("https://chrome.com");

GURL different_origin("https://foobar.com");

- NotificationPermissionContext context(profile());

+ NotificationPermissionContext context(profile(),

+ content::PermissionType::NOTIFICATIONS);

context.UpdateContentSetting(requesting_origin,

embedding_origin,

CONTENT_SETTING_ALLOW);

@@ -133,7 +135,8 @@ TEST_F(NotificationPermissionContextTest, IgnoresEmbedderOrigin) {

TEST_F(NotificationPermissionContextTest, NoSecureOriginRequirement) {

GURL origin("http://example.com");

- NotificationPermissionContext context(profile());

+ NotificationPermissionContext context(profile(),

+ content::PermissionType::NOTIFICATIONS);

EXPECT_EQ(CONTENT_SETTING_ASK,

context.GetPermissionStatus(origin, origin));