Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: chrome/browser/notifications/notification_permission_context.cc

Issue 2149883002: Use the same codepath for NOTIFICATIONS and PUSH_MESSAGING permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/notifications/notification_permission_context.h" 5 #include "chrome/browser/notifications/notification_permission_context.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 task.Run(); 152 task.Run();
153 task_queue_.pop_front(); 153 task_queue_.pop_front();
154 if (!task_queue_.empty()) 154 if (!task_queue_.empty())
155 task_queue_.front().timer->Reset(); 155 task_queue_.front().timer->Reset();
156 } 156 }
157 157
158 } // namespace 158 } // namespace
159 159
160 DEFINE_WEB_CONTENTS_USER_DATA_KEY(VisibilityTimerTabHelper); 160 DEFINE_WEB_CONTENTS_USER_DATA_KEY(VisibilityTimerTabHelper);
161 161
162 NotificationPermissionContext::NotificationPermissionContext(Profile* profile) 162 NotificationPermissionContext::NotificationPermissionContext(
163 Profile* profile,
164 content::PermissionType permission_type)
163 : PermissionContextBase(profile, 165 : PermissionContextBase(profile,
164 content::PermissionType::NOTIFICATIONS, 166 permission_type,
165 CONTENT_SETTINGS_TYPE_NOTIFICATIONS), 167 CONTENT_SETTINGS_TYPE_NOTIFICATIONS),
166 weak_factory_ui_thread_(this) {} 168 weak_factory_ui_thread_(this) {
169 DCHECK(permission_type == content::PermissionType::NOTIFICATIONS ||
170 permission_type == content::PermissionType::PUSH_MESSAGING);
171 }
167 172
168 NotificationPermissionContext::~NotificationPermissionContext() {} 173 NotificationPermissionContext::~NotificationPermissionContext() {}
169 174
175 ContentSetting NotificationPermissionContext::GetPermissionStatus(
176 const GURL& requesting_origin,
177 const GURL& embedding_origin) const {
178 // Push messaging is only allowed to be granted on top-level origins.
179 if (permission_type() == content::PermissionType::PUSH_MESSAGING &&
180 requesting_origin != embedding_origin) {
181 return CONTENT_SETTING_BLOCK;
182 }
183
184 return PermissionContextBase::GetPermissionStatus(requesting_origin,
185 embedding_origin);
186 }
187
170 void NotificationPermissionContext::ResetPermission( 188 void NotificationPermissionContext::ResetPermission(
171 const GURL& requesting_origin, 189 const GURL& requesting_origin,
172 const GURL& embedder_origin) { 190 const GURL& embedder_origin) {
173 DesktopNotificationProfileUtil::ClearSetting(profile(), requesting_origin); 191 DesktopNotificationProfileUtil::ClearSetting(profile(), requesting_origin);
174 } 192 }
175 193
176 void NotificationPermissionContext::CancelPermissionRequest( 194 void NotificationPermissionContext::CancelPermissionRequest(
177 content::WebContents* web_contents, 195 content::WebContents* web_contents,
178 const PermissionRequestID& id) { 196 const PermissionRequestID& id) {
179 if (profile()->IsOffTheRecord()) { 197 if (profile()->IsOffTheRecord()) {
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 if (content_setting == CONTENT_SETTING_ALLOW) { 252 if (content_setting == CONTENT_SETTING_ALLOW) {
235 DesktopNotificationProfileUtil::GrantPermission(profile(), 253 DesktopNotificationProfileUtil::GrantPermission(profile(),
236 requesting_origin); 254 requesting_origin);
237 } else { 255 } else {
238 DesktopNotificationProfileUtil::DenyPermission(profile(), 256 DesktopNotificationProfileUtil::DenyPermission(profile(),
239 requesting_origin); 257 requesting_origin);
240 } 258 }
241 } 259 }
242 260
243 bool NotificationPermissionContext::IsRestrictedToSecureOrigins() const { 261 bool NotificationPermissionContext::IsRestrictedToSecureOrigins() const {
244 return false; 262 return permission_type() == content::PermissionType::PUSH_MESSAGING;
245 } 263 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698