Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2149873002: Move most of WebApkUtils' methods from webapk.lib.common to webapk.shell_apk (Closed)

Created:
4 years, 5 months ago by pkotwicz
Modified:
4 years, 5 months ago
Reviewers:
Yaron
CC:
chromium-reviews, dominickn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move most of WebApkUtils' methods from webapk.lib.common to webapk.shell_apk BUG=None Committed: https://crrev.com/ce6b6238f3e71b0f71bfa63767d0c500936434d3 Cr-Commit-Position: refs/heads/master@{#406038}

Patch Set 1 #

Messages

Total messages: 15 (7 generated)
pkotwicz
Yaron PTAL
4 years, 5 months ago (2016-07-14 00:40:53 UTC) #3
Yaron
lgtm
4 years, 5 months ago (2016-07-15 04:05:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149873002/1
4 years, 5 months ago (2016-07-15 14:24:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/104763)
4 years, 5 months ago (2016-07-15 15:47:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149873002/1
4 years, 5 months ago (2016-07-18 17:09:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 18:12:52 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 18:12:59 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 18:16:37 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce6b6238f3e71b0f71bfa63767d0c500936434d3
Cr-Commit-Position: refs/heads/master@{#406038}

Powered by Google App Engine
This is Rietveld 408576698