arc: Implement safe access to ArcAuthService.

chrome/browser/ui/app_list/app_list_service_views_browsertest.cc

Index: chrome/browser/ui/app_list/app_list_service_views_browsertest.cc
diff --git a/chrome/browser/ui/app_list/app_list_service_views_browsertest.cc b/chrome/browser/ui/app_list/app_list_service_views_browsertest.cc
index 6c150812077dc1557be0cf40b14918d22d8d2ffe..a1c99d0159bc21285341f93ffe622b14d725d1ee 100644
--- a/chrome/browser/ui/app_list/app_list_service_views_browsertest.cc
+++ b/chrome/browser/ui/app_list/app_list_service_views_browsertest.cc
@@ -165,11 +165,16 @@ class AppListControllerAppInfoDialogBrowserTest : public ExtensionBrowserTest {
     EXPECT_TRUE(native_view_);
   }
 
+  // Opens app info for default test extension.
   void OpenAppInfoDialog() {
+    OpenAppInfoDialog(extension_->id());
+  }
+
+  void OpenAppInfoDialog(const std::string& app_id) {
     AppListControllerDelegate* controller = service_->GetControllerDelegate();
     EXPECT_TRUE(controller);
     EXPECT_TRUE(controller->GetAppListWindow());
-    controller->DoShowAppInfoFlow(browser()->profile(), extension_->id());
+    controller->DoShowAppInfoFlow(browser()->profile(), app_id);
   }
 
   AppListService* service_;
@@ -220,6 +225,12 @@ IN_PROC_BROWSER_TEST_F(AppListControllerAppInfoDialogBrowserTest,
   EXPECT_FALSE(GetAppListView(service_));
 }
 
+// Check that the app info can be safely opened for Chrome.
+IN_PROC_BROWSER_TEST_F(AppListControllerAppInfoDialogBrowserTest,
+                       OpenAppInfoForChrome) {
+  OpenAppInfoDialog(extension_misc::kChromeAppId);

[xiyuan, 2016/07/15 17:12:53]

Not sure how useful this is since we always set up ARC in
AppListControllerAppInfoDialogBrowserTest::SetUpOnMainThread.

Maybe we should add a bool param to AppListControllerAppInfoDialogBrowserTest to
run all cases with or without arc ? This can be done by adding
testing::WithParamInterface<bool> to test base, e.g. [1]

[1]:
https://cs.chromium.org/chromium/src/chrome/browser/ui/profile_error_browsert...

[khmel, 2016/07/18 20:23:42]

It seems that Arc initialization in
AppListControllerAppInfoDialogBrowserTest::SetUpOnMainThread has no sense
because:
1. kArcEnabled switch is not set
2. OnPrimaryUserProfilePrepared is called as part of normal profile
initialization.
3. EnableArc is not called.

I implemented as you recommended 1 case - Arc disabled. 2 case - Arc enabled.

+}
+
 using AppListServiceViewsExtensionBrowserTest = ExtensionBrowserTest;
 
 IN_PROC_BROWSER_TEST_F(AppListServiceViewsExtensionBrowserTest,