Handle bad regexs in search.findTopLevelDeclarations.

pkg/analysis_server/test/search/top_level_declarations_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.search.top_level_declarations;
 
 import 'dart:async';
 
 import 'package:analysis_server/plugin/protocol/protocol.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
@@ skipping 21 matching lines @@
     if (result != null) {
       fail('Unexpected: kind=$kind name="$name"\nin\n' + results.join('\n'));
     }
   }
 
   Future findTopLevelDeclarations(String pattern) async {
     await waitForTasksFinished();
     Request request =
         new SearchFindTopLevelDeclarationsParams(pattern).toRequest('0');
     Response response = await waitResponse(request);
+    if (response.error != null) {
+      return response.error;
+    }
     searchId =
         new SearchFindTopLevelDeclarationsResult.fromResponse(response).id;
     return waitForSearchResults();
   }
 
   SearchResult findTopLevelResult(ElementKind kind, String name) {
     for (SearchResult result in results) {
       Element element = result.path[0];
       if (element.kind == kind && element.name == name) {
         return result;
       }
     }
     return null;
   }
 
-  test_startEndPattern() async {
+  setUp() {
+    super.setUp();
+
     addTestFile('''

[scheglov, 2016/07/14 00:18:07]

This test file is specifically for the corresponding test.
Don't put it into the whole class setUp().

It seems to me that the test_invalidRegex() does not need any file at all.

 class A {} // A
 class B = Object with A;
 typedef C();
 D() {}
 var E = null;
 class ABC {}
 ''');
+  }
+
+  test_startEndPattern() async {
     await findTopLevelDeclarations('^[A-E]\$');
     assertHasDeclaration(ElementKind.CLASS, 'A');
     assertHasDeclaration(ElementKind.CLASS, 'B');
     assertHasDeclaration(ElementKind.FUNCTION_TYPE_ALIAS, 'C');
     assertHasDeclaration(ElementKind.FUNCTION, 'D');
     assertHasDeclaration(ElementKind.TOP_LEVEL_VARIABLE, 'E');
     assertNoDeclaration(ElementKind.CLASS, 'ABC');
   }
+
+  test_invalidRegex() async {
+    var result = await findTopLevelDeclarations('[A');
+    expect(true, result is RequestError);

[Brian Wilkerson, 2016/07/13 23:42:37]

The arguments are backward. The better way to write this is:

  expect(result, new isInstanceOf<RequestError>());

[scheglov, 2016/07/14 00:18:07]

See also isResponseFailure in mocks.dart

+  }
 }