Handle bad regexs in search.findTopLevelDeclarations.

pkg/analysis_server/lib/src/search/search_domain.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library search.domain;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/constants.dart';
@@ skipping 97 matching lines @@
     // respond
     String searchId = (_nextSearchId++).toString();
     _sendSearchResult(
         request, new protocol.SearchFindMemberReferencesResult(searchId));
     // search
     List<SearchMatch> matches =
         await searchEngine.searchMemberReferences(params.name);
     _sendSearchNotification(searchId, true, matches.map(toResult));
   }
 
-  Future findTopLevelDeclarations(protocol.Request request) async {
+  void findTopLevelDeclarations(protocol.Request request) {

[Brian Wilkerson, 2016/07/13 23:42:37]

Removing the `async` makes this much harder to read. What was the motivation?

[scheglov, 2016/07/14 00:18:07]

We could use something like this instead.

    () async {
      await server.onAnalysisComplete;
      // respond
      String searchId = (_nextSearchId++).toString();
      _sendSearchResult(
          request, new protocol.SearchFindTopLevelDeclarationsResult(searchId));
      // search
      List<SearchMatch> matches =
          await searchEngine.searchTopLevelDeclarations(params.pattern);
      _sendSearchNotification(searchId, true, matches.map(toResult));
    }();

     var params =
         new protocol.SearchFindTopLevelDeclarationsParams.fromRequest(request);
-    await server.onAnalysisComplete;
-    // respond
-    String searchId = (_nextSearchId++).toString();
-    _sendSearchResult(
-        request, new protocol.SearchFindTopLevelDeclarationsResult(searchId));
-    // search
-    List<SearchMatch> matches =
-        await searchEngine.searchTopLevelDeclarations(params.pattern);
-    _sendSearchNotification(searchId, true, matches.map(toResult));
+    try {
+      new RegExp(params.pattern);
+    } on FormatException catch (exception) {
+      throw new protocol.RequestFailure(new protocol.Response.invalidParameter(
+          request, 'pattern', exception.message));
+    }
+
+    server.onAnalysisComplete.then((_) {
+      // respond
+      String searchId = (_nextSearchId++).toString();
+      _sendSearchResult(
+          request, new protocol.SearchFindTopLevelDeclarationsResult(searchId));
+      // search
+      searchEngine
+          .searchTopLevelDeclarations(params.pattern)
+          .then((List<SearchMatch> matches) {
+        _sendSearchNotification(searchId, true, matches.map(toResult));
+      });
+    });
   }
 
   /**
    * Implement the `search.getTypeHierarchy` request.
    */
   Future getTypeHierarchy(protocol.Request request) async {
     var params = new protocol.SearchGetTypeHierarchyParams.fromRequest(request);
     String file = params.file;
     // wait for analysis
     if (params.superOnly == true) {
@@ skipping 76 matching lines @@
   void _sendTypeHierarchyNull(protocol.Request request) {
     protocol.Response response =
         new protocol.SearchGetTypeHierarchyResult().toResponse(request.id);
     server.sendResponse(response);
   }
 
   static protocol.SearchResult toResult(SearchMatch match) {
     return protocol.newSearchResult_fromMatch(match);
   }
 }