Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4409)

Unified Diff: cc/playback/raster_source.h

Issue 2149843003: Fix MultiPictureDraw issues with GpuImageDecodeController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/playback/raster_source.cc » ('j') | cc/playback/raster_source.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/playback/raster_source.h
diff --git a/cc/playback/raster_source.h b/cc/playback/raster_source.h
index c50c4a0f626a4bdf2e38864d3d910ccf65822b0e..d49c6c29e0f51699d45f23c8c4c14fdd950482d2 100644
--- a/cc/playback/raster_source.h
+++ b/cc/playback/raster_source.h
@@ -118,6 +118,15 @@ class CC_EXPORT RasterSource : public base::RefCountedThreadSafe<RasterSource> {
// of the raster source, since the raster source will access it during raster.
void SetImageDecodeController(ImageDecodeController* image_decode_controller);
+ // Returns the ImageDecodeController, currently only used by
+ // GpuRasterBufferProvider in order
vmpstr 2016/07/14 21:41:54 nit: can you reformat the comment?
ericrk 2016/07/14 22:04:20 Done.
+ // to create its own ImageHijackCanvas. Because of the MultiPictureDraw
+ // approach used by
+ // GPU raster, it does not integrate well with the use of the
+ // ImageHijackCanvas internal
+ // to this class. See gpu_raster_buffer_provider.cc for more information.
vmpstr 2016/07/14 21:41:54 Can you file a bug and TODO(crbug.com/######): R
ericrk 2016/07/14 22:04:20 Done.
+ ImageDecodeController* GetImageDecodeController() const;
+
protected:
friend class base::RefCountedThreadSafe<RasterSource>;
« no previous file with comments | « no previous file | cc/playback/raster_source.cc » ('j') | cc/playback/raster_source.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698