Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2149843002:
Remove command-line switch: cast-encoder-util-heuristic=backlog<N> (Closed)
|
Created:
4 years, 5 months ago by xjz Modified:
4 years, 5 months ago CC:
chromium-reviews, creis+watch_chromium.org, imcheng+watch_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, nasko+codewatch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove command-line switch: cast-encoder-util-heuristic=backlog<N>
This command-line switch was added for testing on an experimental
'backlog' heuristic for measuring encoder utilization in:
https://codereview.chromium.org/2108373002/
From lab testing, the new heuristic works better and more stable than
original deadline heuristic. This CL removes the command-line switch
and makes the new heuristic default.
BUG=chrome-os-partner:55236, chrome-os-partner:54806
Committed: https://crrev.com/823e6812c69134995059824d7c4f88fe084f2bed
Cr-Commit-Position: refs/heads/master@{#405600}
Patch Set 1 #
Messages
Total messages: 28 (17 generated)
The CQ bit was checked by xjz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by xjz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
xjz@chromium.org changed reviewers: + miu@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Remove command-line switch: cast-encoder-util-heuristic=backlog<N> This command-line switch was added for testing on an experimental 'backlog' heuristic for measuring encoder utilization in: https://codereview.chromium.org/2108373002/ From lab testing, the new heuristic works better and more stable than original deadline heuristic. This CL removes the command-line switch and makes the new heuristic default. BUG=chrome-os-partner:55236 ========== to ========== Remove command-line switch: cast-encoder-util-heuristic=backlog<N> This command-line switch was added for testing on an experimental 'backlog' heuristic for measuring encoder utilization in: https://codereview.chromium.org/2108373002/ From lab testing, the new heuristic works better and more stable than original deadline heuristic. This CL removes the command-line switch and makes the new heuristic default. BUG=chrome-os-partner:55236,chrome-os-partner:54806 ==========
The CQ bit was checked by miu@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
xjz@chromium.org changed reviewers: + chcunningham@chromium.org, sievers@chromium.org
sievers@: need OWNERS RS for content/.../render_process_host_impl.cc. chcunningham@: Need OWNERS RS for removing a temporal switch from media/base/media_switches.*.
RS LGTM media
lgtm
The CQ bit was checked by xjz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove command-line switch: cast-encoder-util-heuristic=backlog<N> This command-line switch was added for testing on an experimental 'backlog' heuristic for measuring encoder utilization in: https://codereview.chromium.org/2108373002/ From lab testing, the new heuristic works better and more stable than original deadline heuristic. This CL removes the command-line switch and makes the new heuristic default. BUG=chrome-os-partner:55236,chrome-os-partner:54806 ========== to ========== Remove command-line switch: cast-encoder-util-heuristic=backlog<N> This command-line switch was added for testing on an experimental 'backlog' heuristic for measuring encoder utilization in: https://codereview.chromium.org/2108373002/ From lab testing, the new heuristic works better and more stable than original deadline heuristic. This CL removes the command-line switch and makes the new heuristic default. BUG=chrome-os-partner:55236,chrome-os-partner:54806 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Remove command-line switch: cast-encoder-util-heuristic=backlog<N> This command-line switch was added for testing on an experimental 'backlog' heuristic for measuring encoder utilization in: https://codereview.chromium.org/2108373002/ From lab testing, the new heuristic works better and more stable than original deadline heuristic. This CL removes the command-line switch and makes the new heuristic default. BUG=chrome-os-partner:55236,chrome-os-partner:54806 ========== to ========== Remove command-line switch: cast-encoder-util-heuristic=backlog<N> This command-line switch was added for testing on an experimental 'backlog' heuristic for measuring encoder utilization in: https://codereview.chromium.org/2108373002/ From lab testing, the new heuristic works better and more stable than original deadline heuristic. This CL removes the command-line switch and makes the new heuristic default. BUG=chrome-os-partner:55236,chrome-os-partner:54806 Committed: https://crrev.com/823e6812c69134995059824d7c4f88fe084f2bed Cr-Commit-Position: refs/heads/master@{#405600} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/823e6812c69134995059824d7c4f88fe084f2bed Cr-Commit-Position: refs/heads/master@{#405600} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
