Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2149833005: DevTools: rename SourceFrame.onTextEditorContentLoaded into onTextEditorContentSet (Closed)

Created:
4 years, 5 months ago by lushnikov
Modified:
4 years, 5 months ago
Reviewers:
flandy, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: rename SourceFrame.onTextEditorContentLoaded into onTextEditorContentSet From the current method name, it is unclear that the method could be called more then once. Hopefully, the new name would clarify this. BUG=none R=dgozman Committed: https://crrev.com/075e9a097339e49560f8ff034c5ae280374aaf3e Cr-Commit-Position: refs/heads/master@{#405803}

Patch Set 1 #

Patch Set 2 : rebaseline #

Messages

Total messages: 18 (8 generated)
lushnikov
please, take a look
4 years, 5 months ago (2016-07-15 01:24:43 UTC) #1
dgozman
lgtm
4 years, 5 months ago (2016-07-15 01:36:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149833005/1
4 years, 5 months ago (2016-07-15 01:36:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/263278)
4 years, 5 months ago (2016-07-15 03:11:26 UTC) #8
flandy
What about CSSSourceFrame.js?
4 years, 5 months ago (2016-07-15 15:53:07 UTC) #9
lushnikov
thanks, rebaselined
4 years, 5 months ago (2016-07-15 17:00:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149833005/20001
4 years, 5 months ago (2016-07-15 17:00:59 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-15 18:50:01 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 18:50:18 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 18:51:29 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/075e9a097339e49560f8ff034c5ae280374aaf3e
Cr-Commit-Position: refs/heads/master@{#405803}

Powered by Google App Engine
This is Rietveld 408576698