Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 2149833002: DevTools: Add sendOverProtocol() method for protocol debugging (Closed)

Created:
4 years, 5 months ago by paulirish
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The WebInspector.sendOverProtocol method provides an easy mechanism to test and debug protocol commands. It's intended for developer debugging only. Examples: WebInspector.sendOverProtocol('Emulation.setDeviceMetricsOverride', { ... }); WebInspector.sendOverProtocol('Emulation.clearDeviceMetricsOverride'); WebInspector.sendOverProtocol('Page.captureScreenshot') .then((err, result) => console.log(result)); Committed: https://crrev.com/2a55bf6d555cb626486ca86bc806e33a2d1a7a19 Cr-Commit-Position: refs/heads/master@{#405625}

Patch Set 1 #

Total comments: 2

Patch Set 2 : move to main. rename things #

Patch Set 3 : sendOverProtocol has promise API. #

Total comments: 1

Patch Set 4 : callback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Target.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dgozman
https://codereview.chromium.org/2149833002/diff/1/third_party/WebKit/Source/devtools/front_end/main/Connections.js File third_party/WebKit/Source/devtools/front_end/main/Connections.js (right): https://codereview.chromium.org/2149833002/diff/1/third_party/WebKit/Source/devtools/front_end/main/Connections.js#newcode145 third_party/WebKit/Source/devtools/front_end/main/Connections.js:145: WebInspector.sendOverProtocol = function(method, params, cb){ Let's move this to ...
4 years, 5 months ago (2016-07-13 22:50:03 UTC) #2
paulirish
ready for review!
4 years, 5 months ago (2016-07-14 00:43:38 UTC) #4
dgozman
lgtm. Please add description to the patch (it's empty right now). https://codereview.chromium.org/2149833002/diff/40001/third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js File third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js (right): ...
4 years, 5 months ago (2016-07-14 01:02:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149833002/60001
4 years, 5 months ago (2016-07-14 22:09:58 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-14 23:27:05 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 23:27:07 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 23:29:18 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2a55bf6d555cb626486ca86bc806e33a2d1a7a19
Cr-Commit-Position: refs/heads/master@{#405625}

Powered by Google App Engine
This is Rietveld 408576698