Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2149803004: Add Minikin Hyphenation engine for Android (Closed)

Created:
4 years, 5 months ago by kojii
Modified:
4 years, 5 months ago
Reviewers:
eae
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Minikin Hyphenation engine for Android This patch adds the Minikin Hyphenation engine for Android. Dictionary files loaded by [1] are passed to Minikin in this CL and used to determine the hyphenation locations. Two files are adopted from Minikin in Android Open Source Project[2], in the similar way as we adopted MPL code[3]. With this patch, Android supports hyphenation behind the experimental flag, following Mac[4]. Linux and Windows don't have built-in dictionaries. Supporting these platforms will be later. [1] https://crrev.com/2113933003 [2] https://android.googlesource.com/platform/frameworks/minikin/ [3] https://crrev.com/1882063002 [4] https://crrev.com/1994443002 BUG=605840 Committed: https://crrev.com/bef46ab98172d9a935d37c7d04cfa14fc9657137 Cr-Commit-Position: refs/heads/master@{#405802}

Patch Set 1 #

Patch Set 2 : Rename alias to fallback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/hyphenation/HyphenationMinikin.cpp View 1 2 chunks +85 lines, -5 lines 0 comments Download
A third_party/WebKit/Source/platform/text/hyphenation/HyphenatorAOSP.h View 1 chunk +85 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/text/hyphenation/HyphenatorAOSP.cpp View 1 chunk +234 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
kojii
PTAL.
4 years, 5 months ago (2016-07-15 09:16:58 UTC) #8
eae
LGTM
4 years, 5 months ago (2016-07-15 17:37:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149803004/20001
4 years, 5 months ago (2016-07-15 18:37:40 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-15 18:43:34 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 18:43:44 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 18:45:38 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bef46ab98172d9a935d37c7d04cfa14fc9657137
Cr-Commit-Position: refs/heads/master@{#405802}

Powered by Google App Engine
This is Rietveld 408576698