Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 21498002: Introduce a SVGUnknownElement class for unknown SVG elements (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), webcomponents-bugzilla_chromium.org, eae+blinkwatch, Timothy Loh, dstockwell, dglazkov+blink, dominicc+watchlist_chromium.org, f(malita), adamk+blink_chromium.org, darktears, pdr, Stephen Chennney, Steve Block, Eric Willigers, lgombos
Visibility:
Public.

Description

Introduce a SVGUnknownElement class for unknown SVG elements Introduce a SVGUnknownElement class and have it override rendererIsNeeded() to return false. We now use SVGUnknownElement type (instead of SVGElement) for unknown SVG elements. As a consequence, SVGElement::rendererIsNeeded() no longer needs to return false and can finally behave as SVGStyledElement::rendererIsNeeded() used to behave. R=pdr BUG=231536 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155426

Patch Set 1 #

Patch Set 2 : Add comment for SVGUnknownElement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -58 lines) Patch
M Source/core/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/CustomElementRegistrationContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/scripts/make_names.pl View 7 chunks +9 lines, -7 lines 0 comments Download
M Source/core/svg/SVGAltGlyphDefElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAltGlyphItemElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGComponentTransferFunctionElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGCursorElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEMergeNodeElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFilterElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFontFaceFormatElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGFontFaceNameElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFontFaceSrcElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGFontFaceUriElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGGradientElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGMPathElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGMaskElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGMetadataElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPatternElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGScriptElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGStyleElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGSymbolElement.h View 1 chunk +0 lines, -1 line 0 comments Download
A + Source/core/svg/SVGUnknownElement.h View 1 1 chunk +15 lines, -32 lines 0 comments Download
A + Source/core/svg/SVGUnknownElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/svgtags.in View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-01 08:15:06 UTC) #1
pdr.
On 2013/08/01 08:15:06, Christophe Dumez wrote: LGTM. One nit: can you add a comment in ...
7 years, 4 months ago (2013-08-01 21:05:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/21498002/6001
7 years, 4 months ago (2013-08-02 06:38:54 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-02 09:45:48 UTC) #4
Message was sent while issue was closed.
Change committed as 155426

Powered by Google App Engine
This is Rietveld 408576698