Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2149793003: Move media/capture/content/feedback_signal_accumulator{.h,_unittest.cc} to media/base (Closed)

Created:
4 years, 5 months ago by mcasas
Modified:
4 years, 5 months ago
Reviewers:
hubbe
CC:
chromium-reviews, imcheng+watch_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move media/capture/content/feedback_signal_accumulator{.h,_unittest.cc} to media/base feedback_signal_accumulator.h contains a generic templatised class used by cast/sender/vp8_encoder.cc and capture/content/video_capture_oracle.cc Since media/capture is now a component (and so is media/cast), it makes sense to move it to a common place, media/base being a good option. gn and gyp files are updated, and the _unittest.cc file is moved as well. This cleanup came up while working on https://crbug.com/626125 BUG=618718 TEST= no new code: all builds and unittests working as before. Committed: https://crrev.com/f53aa4322d58784abd314573f0dca2c47ce1a698 Cr-Commit-Position: refs/heads/master@{#405389}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -323 lines) Patch
M media/base/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A + media/base/feedback_signal_accumulator.h View 2 chunks +3 lines, -4 lines 0 comments Download
A + media/base/feedback_signal_accumulator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M media/capture/capture.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
D media/capture/content/feedback_signal_accumulator.h View 1 chunk +0 lines, -109 lines 0 comments Download
D media/capture/content/feedback_signal_accumulator_unittest.cc View 1 chunk +0 lines, -202 lines 0 comments Download
M media/capture/content/video_capture_oracle.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/vp8_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
mcasas
hubbe@ your name was suggested by git cl upload :) PTAL
4 years, 5 months ago (2016-07-13 23:28:11 UTC) #8
hubbe
LGTM However, we really need to clean up media/base one of these days, there is ...
4 years, 5 months ago (2016-07-13 23:36:09 UTC) #9
mcasas
On 2016/07/13 23:36:09, hubbe wrote: > LGTM > > However, we really need to clean ...
4 years, 5 months ago (2016-07-13 23:46:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149793003/40001
4 years, 5 months ago (2016-07-13 23:51:25 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 5 months ago (2016-07-14 01:34:38 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 01:34:47 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 01:37:51 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f53aa4322d58784abd314573f0dca2c47ce1a698
Cr-Commit-Position: refs/heads/master@{#405389}

Powered by Google App Engine
This is Rietveld 408576698