Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2149773003: Clean up some nits in pdfium_test.cc. (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
4 years, 5 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -28 lines) Patch
M samples/pdfium_test.cc View 12 chunks +25 lines, -28 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Lei Zhang
TBR. Really just want to trigger the PDFium bots.
4 years, 5 months ago (2016-07-14 06:30:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149773003/1
4 years, 5 months ago (2016-07-14 06:30:15 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_xfa_rel_gn on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa_rel_gn/builds/770)
4 years, 5 months ago (2016-07-14 06:34:52 UTC) #5
Wei Li
lgtm
4 years, 5 months ago (2016-07-14 18:10:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149773003/1
4 years, 5 months ago (2016-07-15 23:40:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/514e8c914c0e6c2c69167d03786a83b1ebd15d70
4 years, 5 months ago (2016-07-16 00:57:59 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-16 00:58:03 UTC) #11
Message was sent while issue was closed. 
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698