PrerenderingOffliner will abort background load if it sees chrome transitioning to foreground on lo…

components/offline_pages/background/offliner.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_H_
 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_H_
 
 #include "base/callback.h"
 
 namespace offline_pages {
@@ skipping 10 matching lines @@
   enum RequestStatus {
     UNKNOWN = 0,  // No status determined/reported yet. Interim status, not sent
                   // in callback.
     LOADED = 1,  // Page loaded but not (yet) saved. Interim status, not sent in
                  // callback.
     SAVED = 2,   // Offline page snapshot saved.
     REQUEST_COORDINATOR_CANCELED = 3,  // RequestCoordinator canceled request.
     PRERENDERING_CANCELED = 4,         // Prerendering was canceled.
     PRERENDERING_FAILED = 5,           // Prerendering failed to load page.
     SAVE_FAILED = 6,                   // Failed to save loaded page.
+    FOREGROUND_CANCELED = 7,  // Foreground transition canceled request.

[fgorski, 2016/07/14 17:01:45]

nit: Please align all of the comments.

[dougarnett, 2016/07/15 16:00:25]

Unfortunately, this is what 'git cl format' gave me so will be fragile to try to
maintain by hand when updated and format run again.

Trying another approach - putting comments on preceding line - check if that
works better for you?

     // NOTE: insert new values above this line and update histogram enum too.
     STATUS_COUNT
   };
 
   // Reports the completion status of a request.
   // TODO(dougarnett): consider passing back a request id instead of request.
   typedef base::Callback<void(const SavePageRequest&, RequestStatus)>
       CompletionCallback;
 
   Offliner() {}
   virtual ~Offliner() {}
 
   // Processes |request| to load and save an offline page.
   // Returns whether the request was accepted or not. |callback| is guaranteed
   // to be called if the request was accepted and |Cancel()| is not called.
   virtual bool LoadAndSave(
       const SavePageRequest& request,
       const CompletionCallback& callback) = 0;
 
   // Clears the currently processing request, if any, and skips running its
   // CompletionCallback.
   virtual void Cancel() = 0;
 
   // TODO(dougarnett): add policy support methods.
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_H_