Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2149763003: SELECT element: Add HTMLSelectElement::selectedListIndex(). (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT element: Add HTMLSelectElement::selectedListIndex(). We had multiple instances of |optionToListIndex(selectedIndex())|, which causes two iterations over OPTIONs. selectedListIndex() returns the same value, but is more efficient. Committed: https://crrev.com/c97868e41b5ad5c2d12a5520f4e554d3fdeb177e Cr-Commit-Position: refs/heads/master@{#405508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 2 chunks +12 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
Keishi, would you review this please?
4 years, 5 months ago (2016-07-14 08:22:54 UTC) #4
keishi
LGTM
4 years, 5 months ago (2016-07-14 12:19:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149763003/1
4 years, 5 months ago (2016-07-14 15:46:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 17:08:55 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 17:12:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c97868e41b5ad5c2d12a5520f4e554d3fdeb177e
Cr-Commit-Position: refs/heads/master@{#405508}

Powered by Google App Engine
This is Rietveld 408576698