Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Issue 2149743003: cc: Clean up DisplayItemList API (Closed)

Created:
4 years, 5 months ago by Menglin
Modified:
4 years, 5 months ago
Reviewers:
enne (OOO), Khushal
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Clean up DisplayItemList API The DisplayItemList holds data received from WebContentLayerImpl. It processes that data and holds the results as internal data used by cc. Separate the data received from WebContentLayerImpl from the internal data. BUG=625290 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e2989c5ed9269fcdf3f62df07fdb0b898f78d5e9 Cr-Commit-Position: refs/heads/master@{#406077}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -60 lines) Patch
M cc/playback/display_item_list.h View 5 chunks +28 lines, -17 lines 0 comments Download
M cc/playback/display_item_list.cc View 1 11 chunks +51 lines, -43 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
Menglin
Hi Khushal, ptal, thanks!
4 years, 5 months ago (2016-07-13 19:25:36 UTC) #3
Khushal
lgtm. https://codereview.chromium.org/2149743003/diff/1/cc/playback/display_item_list.cc File cc/playback/display_item_list.cc (right): https://codereview.chromium.org/2149743003/diff/1/cc/playback/display_item_list.cc#newcode57 cc/playback/display_item_list.cc:57: DisplayItemList::Inputs::~Inputs() {} nit: new line above.
4 years, 5 months ago (2016-07-14 00:03:04 UTC) #4
Menglin
enne@chromium.org: Please review changes. thanks!
4 years, 5 months ago (2016-07-14 01:01:43 UTC) #6
Menglin
On 2016/07/14 01:01:43, Menglin wrote: > mailto:enne@chromium.org: Please review changes. thanks! enne@, could you review ...
4 years, 5 months ago (2016-07-18 17:39:10 UTC) #7
enne (OOO)
lgtm
4 years, 5 months ago (2016-07-18 17:54:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149743003/1
4 years, 5 months ago (2016-07-18 17:55:20 UTC) #10
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-18 17:55:21 UTC) #11
Menglin
https://codereview.chromium.org/2149743003/diff/1/cc/playback/display_item_list.cc File cc/playback/display_item_list.cc (right): https://codereview.chromium.org/2149743003/diff/1/cc/playback/display_item_list.cc#newcode57 cc/playback/display_item_list.cc:57: DisplayItemList::Inputs::~Inputs() {} On 2016/07/14 00:03:03, Khushal wrote: > nit: ...
4 years, 5 months ago (2016-07-18 18:15:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149743003/20001
4 years, 5 months ago (2016-07-18 18:16:33 UTC) #16
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-18 18:16:34 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 20:10:26 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 20:10:31 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 20:13:06 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e2989c5ed9269fcdf3f62df07fdb0b898f78d5e9
Cr-Commit-Position: refs/heads/master@{#406077}

Powered by Google App Engine
This is Rietveld 408576698